[jsword-devel] What can I do if I want to help?

[Jacky Cheung]

Hi,

Thanks for your hints on GBF tags. I will work on that.

Oh, the module encoding stuff is Style coding. I see. In C, Strings are 
char[] with null (0) as the last element. manipulating Strings in C is 
not straight forward. As a result, they tried to enum the encoding 
values by integers (and it takes time to enum). However, String support 
in Java is much much better. I expect similar things exist in the code 
and slow down the code. I think we can fix them when most of the Sword 
functionality are working. We can focus on porting tasks at this moment.

Jacky

P.S. Hey, thanks for removing unnecessary task from 'all' task. The task 
completes in  1-2 minutes. In the past, it takes 11 minutes in my 
machine...

Joe Walker wrote:

>
> Hi,
>
> Wow.
> I'm impressed. Very impressed.
> I've just applied the patch, and updated CVS.
>
> I had just moved the checkstyle stuff into the new jsword-support cvs 
> module, but I checked the patch in there anyway.
>
> In the code you asked "Why is the module encoding stored as a number?"
> And I have no idea why. Mark wrote that bit, but I expect he just 
> copied it from the original C source, and there may well be a good 
> reason for it to be a number there.
>
> I've just done a fairly major check-in, including lots of package.html 
> files, an upgrade to jdom 0.9. I'll try to keep my check-ins regular 
> so there aren't too many clashes.
>
> I'll stay clear of the GBF tags.
> You may well discover that the BookDataListener interface doesn't have 
> enough methods on it. The idea behind BookDataListener is to be a 
> simple way to help a data source create the OSIS data. It is a bit SAX 
> like in the way it does this, I'm sure you can see. I picked the OSIS 
> tags that I thought we were most likely to need, but I may not have 
> got it right.
>
> Thanks,
>
> Joe.
>
> Jacky Cheung wrote:
>
>> Hi Joe,
>>
>> Attached is my updates. Here is a short description of what I have done.
>> 1. build.xml, custom.xsl
>> - Add fork to JDepend task
>> - To avoid hardcoding path in custom.xsl in checkstyle
>>
>> 2. Updated JUnit tests so that no garbage files (foo.la and tmp.ser) 
>> will be created.
>>
>> 3. Updated SwordBible, SwordDictionary, and SwordCommentary so that 
>> they can handle non-Latin-1 module (e.g. Chinese Bible, Hebrew) 
>> properly.
>>
>> Anybody working on "GBF add tags: RB, WG****, WHO****, WTH****, WTP, 
>> WT*******" in bugs.txt? I am going to work on this.
>>
>> Jacky
>>
>> Joe Walker wrote:
>>
>>>
>>> Hi,
>>>
>>> I've made the change you noted - thanks! I didn't realise you could 
>>> fork the JDepend task. It might help me work out why I've found the 
>>> junit task so troublesome.
>>>
>>> I think you should be able to change whatever you want and use cvs 
>>> diff to send me a patchfile. I use eclipse to do all my cvs access, 
>>> but the cvs console tells me that the command would be:
>>>   cvs diff -N -u "/jsword"
>>>
>>> When I've needed to create diff files without access to cvs then 
>>> I've used this:
>>>   diff -ruN jsword-orig jsword-modified
>>>
>>> I would hazard a guess that -u meant unified diff format, and -N 
>>> meant include new files, and that cvs does -r (recursive) 
>>> automatically.
>>>
>>> I hope to do another beta release soon so I'm trying to concentrate 
>>> on fixing bugs.
>>>
>>> Hope that helps,
>>>
>>> Joe.
>>>
>>> Jacky Cheung wrote:
>>>
>>>> Hi,
>>>>
>>>> I wanted to give a handle in the project. What can I do? I have 
>>>> looked at the ant script and found that the JDepend task requires 
>>>> fork="yes" to work without puting the JDepend.jar to ${ant.home}. 
>>>> However, I cannot commit the build.xml back to CVS. Is there 
>>>> anything I should apply for? Thanks.
>>>>
>>>> Best regards,
>>>> Jacky
>>>>
>>>> _______________________________________________
>>>> jsword-devel mailing list
>>>> jsword-devel@crosswire.org
>>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> jsword-devel mailing list
>>> jsword-devel@crosswire.org
>>> http://www.crosswire.org/mailman/listinfo/jsword-devel
>>>
>>
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
>