[xiphos-source] [crosswire/xiphos] a22e20: Fix parallel tab crash: call correct update functi...

LAfricain noreply at github.com
Fri Mar 13 15:48:38 EDT 2026


  Branch: refs/heads/master
  Home:   https://github.com/crosswire/xiphos
  Commit: a22e20c1f786eb9f6d84216e1fb3bd2858a8365f
      https://github.com/crosswire/xiphos/commit/a22e20c1f786eb9f6d84216e1fb3bd2858a8365f
  Author: L'Africain <fr.cyrille at tiberiade.be>
  Date:   2026-03-13 (Fri, 13 Mar 2026)

  Changed paths:
    M src/gtk/preferences_dialog.c

  Log Message:
  -----------
  Fix parallel tab crash: call correct update function based on mode (#1287)

In on_entry_activate(), main_update_parallel_page_detached() was called
unconditionally, even in tab mode where the detached widget does not
exist, causing a SIGSEGV. Now checks settings.showparatab to call
the appropriate function.

Fix parallel tab: use correct update function and refresh navbar on module removal

- In on_entry_activate(), replace showparatab if/else with direct call
  to main_update_parallel_page_detached() which handles both tab and
  detached modes via html_parallel_dialog widget
- In ps_button_remove(), call gui_navbar_parallel_set_module() after
  removing a module to update navbar with new first module's v11n

Co-authored-by: lafricain79 <lafricain79 at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/crosswire/xiphos/settings/notifications


More information about the xiphos-source mailing list