[xiphos-source] [crosswire/xiphos] fba766: fix for Double-clicking on a word to open the dict...

[LAfricain]

  Branch: refs/heads/master
  Home:   https://github.com/crosswire/xiphos
  Commit: fba766e3876448404a0e04754d2a26ca754b6ca0
      https://github.com/crosswire/xiphos/commit/fba766e3876448404a0e04754d2a26ca754b6ca0
  Author: L'Africain <fr.cyrille at tiberiade.be>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M src/main/display.cc
    M src/webkit/wk-html.c

  Log Message:
  -----------
  fix for Double-clicking on a word to open the dictionary doesn't work properly #1212 (#1275)

* fix: use GDK_SELECTION_PRIMARY instead of GDK_SELECTION_CLIPBOARD for dictionary lookup on double-click

When double-clicking a word to look it up in the dictionary, Xiphos was
reading GDK_SELECTION_CLIPBOARD, which is filled asynchronously by the
WebKit COPY command. This caused a timing issue where the previous word
was looked up instead of the newly selected one.

The fix reads GDK_SELECTION_PRIMARY instead, which X11 fills
automatically and synchronously when the user double-clicks a word,
making it immediately available for the dictionary lookup.

The now-redundant WebKit COPY block (#ifdef USE_WEBKIT2 ... #endif) has
also been removed as it is no longer needed for this functionality.

Fixes #1212

* Fix #1091: show commentary introductions in chapter display

Commentary modules like MHC store introduction text as entry
attributes (Heading/Preverse) like Bible modules do, but
GTKEntryDisp::displayByChapter() never called CacheHeader()
to retrieve and display them.

Add CacheHeader() call in the verse loop of displayByChapter()
to match the existing behavior in GTKChapDisp::display().

* Fix: show chapter introduction after chapter title, not before

In getVerseBefore(), the intro material was appended before the
chapter title (display_chapter_N block), causing introductions
to appear above the chapter number. Swap the two blocks so the
chapter title is displayed first, followed by the introduction,
matching the OSIS spec where <div type="introduction"> follows
<chapter sID/>.

---------

Co-authored-by: lafricain79 <lafricain79 at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/crosswire/xiphos/settings/notifications