[xiphos-source] [crosswire/xiphos] eb726a: Fix parallel tab: duplicate navbar and navigation ...

[LAfricain]

  Branch: refs/heads/master
  Home:   https://github.com/crosswire/xiphos
  Commit: eb726a9401280becbc789267246a7e673c19438d
      https://github.com/crosswire/xiphos/commit/eb726a9401280becbc789267246a7e673c19438d
  Author: L'Africain <fr.cyrille at tiberiade.be>
  Date:   2026-03-11 (Wed, 11 Mar 2026)

  Changed paths:
    M cmake/source_version.txt
    M help/fr/fr.po
    M src/gtk/navbar_versekey_parallel.c
    M src/gtk/parallel_dialog.c
    M src/gtk/parallel_tab.c
    M src/gtk/preferences_dialog.c
    M src/gui/navbar_versekey_parallel.h

  Log Message:
  -----------
  Fix parallel tab: duplicate navbar and navigation broken after changing modules in preferences (#1277)

* New help translation for it. Minor correction for French and Italian i18n.

* New strings translated

* Correction of some errors from the last commit

* Fix parallel tab navigation broken after changing modules in preferences

Root causes:
1. navbar_parallel was defined three times (parallel_tab.c,
   parallel_dialog.c, navbar_versekey_parallel.c), causing each
   file to use its own separate instance. This also caused a
   duplicate navigation bar to appear when opening the parallel
   tab, as each definition created its own navbar widget. Fixed
   by keeping the single definition in navbar_versekey_parallel.c
   and using extern in the other two files, ensuring a single
   navbar is created and displayed.

2. ps_button_cut() stored abbreviations in settings.parallel_list
   instead of full module names (the treeview column 1 stores
   abbreviations). After a cut, backend->get_SWModule() received
   an abbreviation and returned NULL, silently breaking all
   navigation. Fixed by converting abbreviations back to full
   names after g_strsplit().

3. After changing parallel modules in preferences, navbar_parallel
   .module_name was not updated to reflect the new module list.
   Added gui_navbar_parallel_set_module() to update it, called
   from on_dialog_prefs_response() and on_dialog_prefs_close().

Fixes: #1088
Related: #1272

* Fix missing include for gui_navbar_parallel_set_module

* prefs: add drag-and-drop reordering and double-click adding of parallel versions (fixes #702)

* fix: restore cmake/source_version.txt needed for build

---------

Co-authored-by: lafricain79 <lafricain79 at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/crosswire/xiphos/settings/notifications