[sword-devel] Win32 FileMgr Subclass

[Greg Hellings]

On Sun, Jul 19, 2020 at 2:40 PM Tobias Klein <contact at tklein.info> wrote:

> Thanks for giving me the background on this, Karl! I appreciate it!
>
> Is Xiphos the only frontend that has been patching Sword for this purpose?
> Then I suppose all other frontends suffer from this issue, huh?
>
> Thanks for putting in the work to make Sword behave well with non-ascii
> path names!
>
>
>
> Best regards,
> Tobias
>
>
>
> *From: *Karl Kleinpaste <karl at kleinpaste.org>
> *Sent: *Sonntag, 19. Juli 2020 15:23
> *To: *SWORD Developers' Collaboration Forum <sword-devel at crosswire.org>
> *Subject: *Re: [sword-devel] Win32 FileMgr Subclass
>
>
>
> On 7/18/20 1:53 PM, Tobias Klein wrote:
>
> No, I have not tested my code properly with non-ascii characters in paths
> / file names.
>
>
> The original cause for the Xiphos patch to Sword was because, 11 years ago
> when we introduced the Win32 port, as GnomeSword was renamed Xiphos, one of
> our first new Windows users was a fellow in Spain who wanted to review it.
> His name was Reuvén, and that was his login name on his Windows machine.
> So of course the path C:\Users\Reuvén was involved, and that 'é' is what
> killed us.
>
> What dies here is Sword itself.  Xiphos was fine, being already based on
> glib, but Sword's collapse came as soon as Xiphos made its first filesystem
> call.  The patch glib-ifies Sword, where glib works rather hard at hiding
> the UTF16 boundary from the application.
>
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/sword-devel/attachments/20200720/55cc9a07/attachment.html>