[sword-devel] Bishop 1.6.2pre / test / comments / translations

[Mill J]

I've found a small bug that is easy to reproduce and crashes Bishop
1.6.2pre every time, at least under Android 6.0.1.

If you initiate a search then try to search again(i.e. correct a typo)
before it's done it will crash the app.

Looking at the code reveals that there is a check in place for empty
strings but not for an existing search. I'm not too familiar with jQuery
but a quick fix should be as simple as adding a bool that gets reset when
the search is over and any new search could check the value.

Thanks

mill-j

On Mon, Dec 7, 2020, 10:15 AM Mill J <millj.code at gmail.com> wrote:

> Tried the pre-release. So far I like the design and features. Good job.
>
> I have a question though. Have you thought about using the Play Store's
> beta(open/closed) channels for pushing out beta releases? This way users
> can sign up as beta testers and get updates through the Play Store without
> uninstalling/installing constantly.
>
> Thanks
>
> mill-j
>
> On Sun, Dec 6, 2020, 12:15 PM Troy A. Griffitts <scribe at crosswire.org>
> wrote:
>
>> A big thank you to everyone who have sent me translation updates
>> privately.  I have committed what I've received.
>>
>> I was also reminded that if you have Bishop installed from the Google
>> App Store, you will need to uninstall before you can install the
>> pre-release apk.  For some reason, Android won't let you update from
>> different sources.
>>
>> Thanks for all the work and contributions!
>>
>> Troy
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://crosswire.org/pipermail/sword-devel/attachments/20201208/8ba1a2f5/attachment.html>