[sword-devel] installmgr (and xiphos) crashes (svn 2831)

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ZIP files would be OK. But these architectural changes:

The thing is that I'm either lazy or just don't have too much time on
my hands. And since I have no write access to Swords SVN to fix
anything, it were just so much easier for me to fork on git than to
try to work with the current project, submitting patches by e-mail,
fighting for getting my changes accepted, taking time to explain every
single change I make or plan in detail, etc...

It just doesn't work well for me. :(

So currently my short answer is: NO.

Sorry,
Jaak



On 26.06.2013 16:44, Nic Carter wrote:
> (Sorry for the top reply)
> 
> IMHO it would be easier to switch to downloading a ZIP file of the 
> module than it would to add the infrastructure required to
> generate a custom listing of file names. I encountered the issues
> you point out (and agree with you) & gave up. If/when the CrossWire
> httpd server changes (& the HTML output changes), the installmgr
> code will break :)
> 
> My vote, long ago, was to switch to downloading ZIP files instead 
> of each individual module file, but no one has implemented that
> yet (would you mind looking, Jaak? My c++ skills are very rusty, as
> you have seen!) :)
> 
> Sent from my phone, hence this email may be short...
> 
> On 26/06/2013, at 23:35, Jaak Ristioja <jaak at ristioja.ee> wrote:
> 
> On 26.06.2013 16:25, Greg Hellings wrote:
>>>> bserver directory listing output (which is what I think it 
>>>> does).
>>>> 
>>>> V E R Y   V E R Y   B A D   P R A C T I C E ! ! !
>>>> 
>>>> 
>>>> Parsing server output is bad practice? How in the world did 
>>>> you reach that over-zealous conclusion?
>>>> 
>>>> --Greg
> 
> I didn't. It is not safe to assume that web servers provide similar
> output for directory listings. They might even do AJAX or something
> which might only be reasonably interpreted by human (if at all:).
> 
> Example: The current code doesn't work when links start with <a 
> id="x" href=" because it only searches for "<a href=". Even
> parsing the HTML properly would not be enough in some cases.
> 
> Therefore, it is not reasonable to try to parse the directory 
> listing output of the webserver. Instead, better mechanisms should 
> be used, e.g. custom-format index files, e.g. with a format like 
> "one filename/URL per line, separated by '\n' characters.". Sword 
> would just need to download a single file (instead of the webserver
> directory output listing), and parse that.
> 
> This is much easier to parse and handle error conditions, no need 
> to try to interpret HTML, filter links etc...
> 
> Blessings, Jaak
>> 
>> _______________________________________________ sword-devel 
>> mailing list: sword-devel at crosswire.org 
>> http://www.crosswire.org/mailman/listinfo/sword-devel 
>> Instructions to unsubscribe/change your settings at above page
> 
> _______________________________________________ sword-devel
> mailing list: sword-devel at crosswire.org 
> http://www.crosswire.org/mailman/listinfo/sword-devel Instructions 
> to unsubscribe/change your settings at above page
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)

iQgcBAEBAgAGBQJRyvQnAAoJEEqsYmEt1rCO7XA//R9z97nEUqlXA04mqIGDd6rc
g+jgzulo2kek4/9WXnWDlIuwNwEwamZCOOVHqQTIOcH1YP2oTJnyzBigcuU6rPap
KeKRCVMFH0JXlg8EGgKY2U7cpriyfRTpJRL5645nYSWe12r2WKSz7mJzWEL776PK
teFbu8UlNQrIH3UU3I6xBvaDq2pTR9TvtIjBtoda/RF8r5jy9BnCKNN55H0/jRu6
cNowpyo2W9dM5G3rYXaJyUA84qR4kLPLFdY6T7Oq/zu79bkyiimctEXQp9ygB/SK
padRmZYm3aWOEdFJFCMLha9MOd86ComQvAVbi2JpTDtq+NDP+9oABqhZtr+WZqj/
I9GOKwRxgPwjATzkQbFvIaIbaIaT6lgeFpVwZmTC7qQVy9lpZnpywE32H4XEw8tj
CSDUJSVWp6dzqLhJ0BXnHThy/yWWMmUGlcoUUoOyjpKpFd4fGWZVNLeU9nqTHobH
cDJrqT56AJGGZrxI/Uu8nQD8nxRk6t4oUanXLwYc34wd79vPjfmNiWDFw9plFcOg
Oqr0V2Aaj7S+taL2gMIEPGQwCGcumzx6Z2C+LBajK/EN3DG1RVurAkr9Sxhs5Rah
iu6tP8Uh5j7f8urngDf/mifWGIryyN5YAaIj9dQH/EdqS4TRpV8OnC9AVYMOPazg
TzZJqhlkFB368S/tQTNv0RTEdtJWuFTlCUpvAaW/SkOw5ciY88WulAPAoy/VncXa
frNRy+X5lGfOaXRMQbQoK93b6PlrRNyfGn0seXdXdbvphRqfM9w5z1kh0Z7CTTqs
2JtV+vPC4E8H/1rMwUqAeO6yQEAR/7Es1QJbX4+FZlQ/ahEiqNzc5TPQZctvK5AQ
9F0+N+3gSiOmR1jdvqTc7VdH0upDgcmNn4rS3KUOCIdpAifiPREFssNRuL710X04
Owk7YDsKMeH12N2W7DlK2FiMRsH3jkQPipI8ovG19Z3n/X/HububTn+iYxaD78CF
etdoUYgf1ePDyH9AS+L+aSycFJjuOovEAvvjRJ+vH/rPQDsqAEE3Lx4/zl6Z/nnE
9dg7tY8nlZtWYUq/eZC3bTDeUk4hdat3c2kxC9VwOaRLuNwmfq5HqPwi0V8Yr+cm
+Q+ba2uEIQP+/XQTmxdC/LpW0cuCCxZkar0iq7wja44WQrXtQlSQfc0dbsONp6YN
VcYyF5++sDYYX8KFakDAHKnNQI8tDtKnzUIWkmER+l5o3vhSVe3wUrTICSKrMEwV
gH63QRezSTqM//qHHoNG9KhftE12aN92yMoTjR5YkocUhgSckla+mKalgKGMIdal
1RsIWsaTOh+NA1Sey7wCuBaQpn0fUVP92myg+KTDmAp7X4m0/EMcSnzxxm0FZQkw
4sqKMWlTsBjdJ0YAsSMLJF6+LAl+jC+Po+CuXyAHdwzT4fBJZVGcAkeO7MgVkmzQ
Qu/L3fbV5evb3qBis29FINEQ2qB5kuPGD6EQBIfPn861Eq6LFVZWupVECSEb5o/W
vPMFVGPTQEDXF0aEoE5GhfZQ3pT7x2tyHdZjnsWogqATMYp34gdZrVnrItLdT0Dx
UmceeiT4Odwo5JGAtrrOUN7nLETj/f6eYAbwAYvOOukcNDTk3CjiFx6BBO0CNbWs
vmeXiWipMJCJIB7iOJRM1TTbSEcx2iUHSBHRkBg8RALqcpCRjcF1y4V8oRRhBTdi
F1+amSvCDNOQ9r/cHbeozDhEyc4fJqP/bBKlyEB3jHWMVe3nxSCtOxhJ4KLiVifI
E1KwTHMPxunY3jNItdB8Dkawcdrf3P0Qcq6hWlWzjUm5D8g3CUAecHgPJYMyAhk9
zrkYpWmDXnTvNJLDYaZGB2CNIIMdom/vyeXQEaXJhSaKuIx6IZU7k4q+hJnJBTbs
zXnknd278XUjY3xKqgo1c6E7JvUca/TTpxwKHg2Xwz9Y6UKWIyGCgoUUo2QfTXxW
8TLpyMtyM0dVN34QIgFaIkOWpF7QqzQZOOLJ6NkvzqOgMBrhoR1Clkn7veuR1swA
OGlElwULvzGG/7T+k7rtFPdxFv4oa0Dkj+GPW51HWVXtB6TWYPboida1Gj1pBBNE
0DFkSOph7RPMntzioWsQIAlLycqgBslX0DytvZ0hxn0xJ+GBAEolY4t7vTgyZEUi
4p1aEnDd6ZI81dGB7VUwkrE4UW9CEKOE6QpQMN7in6ARkWhdQn7KPrNt7xa7VaUQ
aYv+Pd8ILIf5kkW1GEzCbNxzW6v4Y6objkp8Fy5tT4+Ko1XX5BWM/0/IW0ZDd8rs
PNXpj+oEi/ibPoW1gc5j7TtPUIkc7KamKACHUl7Bo1gyVVV0+zSBaqIU2LaC72aL
QsaDNbKwFTh/MkwiV2XQeMKzrJoq4f3k/8NZQS886gC1dvrP773b7Q2HC9yYgJu9
8j5Ae2EfHVVDU8QqUr+mEfj5AN88v919DHQGqPFaMAP1qsQRWRFpTGks2zWmLzEE
rYvi7MvoRh36nvUAu3ocRBzZfUwUo/9pzA6xNbUKEsiE620A4rnqKa7AKySSTbwg
W2o0qWXkkJZ6JMuc3xNHh9AcU+RTNy0hflI5BENL8htLlRzRsOtK8D/sfZsukVlu
Aodl75QIQPEDr8h2aAkQEvo4wlAAM+mXul9+s+NtOPFlg+6WlSaYZKFLUPK1UIuH
yGLRRp7QhfSsdxu/0YAs2KhdFCFcnFfsks3syYNgUWn0tSw7V8GTL8vfa3cFXTWl
tL1BaPpkd4gV4AlS+6zH
=Jy/e
-----END PGP SIGNATURE-----