[sword-devel] Patches to fix compiler warnings

Jaak Ristioja jaak at ristioja.ee
Sun Jan 20 10:36:04 MST 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

Is there any progress regarding the patches I sent? A month has passed
since I submitted them and there has been no feedback.

Blessings
Jaak


On 03.01.2013 23:11, Jaak Ristioja wrote:
> On 02.01.2013 09:22, Nic Carter wrote:
>> Thanks for these.
> 
>> Hopefully some kind soul will apply them?
> 
> When I first posted the patches I thought I'll wait until 2013
> before taking any further steps. But it has been a very busy time
> for me and possibly also for the Sword developers, so I think I'll
> wait a little more until I have more time to work on Sword (maybe
> some time next week).
> 
>> For those who are interested, some fun articles related to this 
>> stuff:
> 
>> * 
>> http://inessential.com/2012/12/31/coders_in_the_hands_of_an_angry_god
>
>> 
> 
> * http://boredzo.org/blog/archives/2009-11-07/warnings
>> * (more appropriate to Obj-C) 
>> http://ashfurrow.com/blog/seven-deadly-sins-of-modern-objective-c
>
>> 
> I can't fully agree with the "treat all warnings as errors"
> approach, since as far as I know there are some warnings which are
> very difficult to work around, e.g. warnings about "#pragma STDC 
> FENV_ACCESS ON" not being supported by certain compilers or Clang 
> warnings about struct/class padding. Some warnings can be
> annotated with comments (which might also show up in the warnings)
> so that developers wouldn't try to fix what can't be fixed in a 
> straightforward manner.
> 
> In my opinion short variable names are also fine if they are
> either simple temporary variables, if their declarations are well
> documented or if their semantics are obvious just by looking at
> their type. Of course longer and more descriptive names are
> recommended, but in case stuff doesn't fit well horizontally I've
> usually abbreviated them, especially if their scope is limited. The
> biggest issue with short variable names is that they sometimes (and
> not very rarely) make code difficult to read and understand.
> 
> 
> Blessings, Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQgcBAEBAgAGBQJQ/Cr3AAoJEEqsYmEt1rCOFY5AALgNSBaRQFVufVg9qQtDXBbW
prMqRqMolx3Es9mTmCCsDaXzpYeNZagx04aNma7wrKE3LN1FvHyMqMA4+ajHUuEi
rBDuZLSkrfn2xWWdaC2uh0qmVQrfvfip07TyuordOQT5HtRKWIPTu8q00YxvpHUX
QN/YfafmVfr4815j+t+tWmVt3pFiHc3N1iFYBDy85NFbQvKCJVwZEKyhShU0O8mv
lFBHr2GsuiTJDxc2RgGIDVIgPrEk0MOH2IFkmeXVj0/Ms6pzjDHNwM48vAD3K5e3
BzUTGyvlH/HMjWazqCwNxxFoLYwBTJOsySlh9aLBGVdN0WyLyYMadtzmMrkcJ6od
uhPA+e801+vvEKkNKcvxjR0+x8cWNjLTEuaSXMX16TELHC5bP28IsRnUj+0I6VAf
Sj5ROn3KeyFE2gGkq7K1setMV7yXb8IHGpF6/U+l7+O0rC7peIfMG/RQijFr+4ON
I/eOkv+AzUgKhAkJDrfr8KNjD0oLx6F2ojvo7N/otVsVJE8nfe0Dv0cruSWq+AUh
JAdEF+Mcm2Z7hSseXDNBYuYiB3TjjI0PcGvCM4blshCvzZ7LsVzaiq5Gt7EMj2Yw
yo1Y7yMxQwopGXMvaWC90QmSmQkKZAP4uJmKFHdZuPBeChWJXGJ514pcDYbW6QVL
MTold54iogp7Z/nJAnFUDK/y+0fmYFPnsb2BKLbY1BkE7GAq3lUG8Mq/Kwz/lkYN
JNZtN0yWyupm4aSkYWBrzGq0Kgz4W/xLMRIqS9BjeUfQ+Dhb+LaMF+yVG1k0zX5s
6Wz7dtWF6tjIjWHUJTphZQJ4kyobmnmu5ymFS7itsgwHEL2NjGjAHQtANqB91Eyi
SuQyL77Xs02wm8OmdNFkpj2GJeA9MVVZtyNRuz9TFAzKQrucVDVIeaRmx9NjE/VS
oO89MqCiu0MG+OAMIp7p7y2MYZ5dEcsIbGd7wvfghUeJMUcM7dQKtgWE+jE/LKsf
zwNaQ1oeyvKK85z3H50rqX5+BsdueRdgaCt8gueqc8kNkzCXMjSfswFwjiAXmcH7
0rVrDMjCpXwDuoMkcVd/I/l7bCusRtiEyCBjbp7LVm4ryOBK5Te+iMR5MMMb3KD/
Lb1D73xMot8ly+X+8N7f9//qn7DwteF3JrjDX2I85kN3wC41Wd9gLblRghAVuMvz
VefmNP6CpgnyDPh7RyjNBdc6p0sR1T7LWdMFoHh4LHxNvB3JYqlDIypg3tmcA4qP
W4IktBfFe6oWtJ2r+9Xtx2deJjkLJEhfCrw3O792jrH6kIXEnG70dLVFGuDHnB3U
lROVFWHWqwZGGwFQR0YYeplwRjXACtf6zeBtrbqigxyHxeXxAHpu/K6eDYrSxyzj
b0WHwfzBPl4EOTNLiVYWTkPV+kAw47VTLMR7ME8uJef7vuPdIC4pFYCRCA65/wa1
+f3QGGy8AiMc+1D2Sd8ceIaqUjOv8X4GVZ+s1qx4QH5Pjxw8kUm6mmo/MppztZBc
uR1oc2LAH5uzYUMGy1YmFNzqFMeWkfTD2W/1eiEMa17BZ/aiM4vscPsYte8BsO+1
m1wWgi9PjtfLpeKcqdJgjPS2/LlsExdlHDrZIx47A6mWaDcYr7E/iiHzuFpFCJvH
SFbESkhxOapXStckxro55++c2fiNk9IBhPvvLRe+kJTbSBnRYo2shIzypGwdgOxa
nSI6P4z1kC7LTnDDRMSk1vrhR603POmFzjDJBtrDIIP9p3iindFN5btLIr10OctA
TYfHk02/0U0mctzVdJYmt9bNUB6AtXADJsRkCJhjzq4pYOmjf5BbIS6TJ4cSAuQq
d028TjM0kRJdXboF7pK9OyYGFUz3y45N8u/A+WwU65SA22t9NNqHKYmh4UH8hZdL
5pQ0XkfsEIiBCyVKxMnRJV6X+padziD8bqkA/rB/7ZOFVEIoSFvncAsQHcTeeWBM
0nR0Ub7pymmOba6STyUbAsz91cXBYPb6PFVIfjxjqVS2U8PJIFR0hlA6f+0mZ54f
gu5pQ07PDBJPf8FC6c+HssZR3DCz/7CTgzG/C8Dd9wyoLEjh86WoRIWIlZyhr9U6
XdZ080J0EvZJU0CgaICi3tPvLa69T1TFCEJL7KkQOgRSQ9Fa+QfbSYT0sy3Upu8l
KvJGtDaRfKfhV3aAwXrg/Mx8/sPcs0W86g5R3IjeA+GHB4NRDBSZue341MtPM8qq
KewJNU0ExlKGFtaSdw2c3jnzprdKvKAnIbLfPwjm8tO3xDtAM6mcPoDrvvF915HC
GILzbWNUi7d++gVjmsUQ/MkXMDfp6auHG5i6b1+mokkG+fOoaRS/80Ok87W15HoG
5AqCULWHqeKNVkmc7gDWlMEL3tW2zwim7RWjTE/v7de3ILlpPe1nvxaudBZemPT1
etG+vACio52h3DOanKsme/NORlsVWEb9VWewMxErP7GbCwRh3izUpShGmAZ6oD3h
W+KybocZjJiBsDw4nvUorofgV/uW2OIXkvvynMW296m1leo7FymQHXcXC81wIIpw
/EID1Wi5Sx+frKhVXd4FSfhfpVURTl0gmt+d0j92ODkIFimI+udloZru02noTymN
RJS6Rmo+G0fr6ySuZ1euXNrSozmGTcJrTy5nxnfP66uZkPM/fMOf6Vmm+50NZdVD
AgmrAwzvup8OBb6PPhGmcnPMSlHXerghV5RmJdJj3aYO3jyJuyq2/VZGKDm7QNcQ
9u/GdN2pLOIODBg9R9bB
=lTc4
-----END PGP SIGNATURE-----



More information about the sword-devel mailing list