[sword-devel] Patches to fix compiler warnings

Jaak Ristioja jaak at ristioja.ee
Thu Jan 3 14:11:28 MST 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02.01.2013 09:22, Nic Carter wrote:
> Thanks for these.
> 
> Hopefully some kind soul will apply them?

When I first posted the patches I thought I'll wait until 2013 before
taking any further steps. But it has been a very busy time for me and
possibly also for the Sword developers, so I think I'll wait a little
more until I have more time to work on Sword (maybe some time next week).

> For those who are interested, some fun articles related to this
> stuff:
> 
> *
> http://inessential.com/2012/12/31/coders_in_the_hands_of_an_angry_god
>
> 
* http://boredzo.org/blog/archives/2009-11-07/warnings
> * (more appropriate to Obj-C)
> http://ashfurrow.com/blog/seven-deadly-sins-of-modern-objective-c

I can't fully agree with the "treat all warnings as errors" approach,
since as far as I know there are some warnings which are very
difficult to work around, e.g. warnings about "#pragma STDC
FENV_ACCESS ON" not being supported by certain compilers or Clang
warnings about struct/class padding. Some warnings can be annotated
with comments (which might also show up in the warnings) so that
developers wouldn't try to fix what can't be fixed in a
straightforward manner.

In my opinion short variable names are also fine if they are either
simple temporary variables, if their declarations are well documented
or if their semantics are obvious just by looking at their type. Of
course longer and more descriptive names are recommended, but in case
stuff doesn't fit well horizontally I've usually abbreviated them,
especially if their scope is limited. The biggest issue with short
variable names is that they sometimes (and not very rarely) make code
difficult to read and understand.


Blessings,
Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQgcBAEBAgAGBQJQ5fP8AAoJEEqsYmEt1rCOAedAAK/zdbAYoBA5aIBq2CtlbCRl
o70jF0ORE1u/aVMtZ9tsfipbknYKupVOYWEwBJ8ZpO20fSUag4NYrmySThD4LvY9
1sVex6LEckT9lsMVEnNNOGw6b5nJ0JyPIuCYG1cxsFg/pprsgFY26eZZiIHNj1zQ
6/KVgkjG95QNncPRcY4hAjvAOgYru84AQroz0Cy5K/GJBMxitDVfoTLH9+dmLt7T
+0Ovg8X+/1vnO11PYxtHLXSL05kN1Ct4ETU86Os0A9MvrzUcgVkVzsT9qiAMmrvN
3dBF76ei8TU2DsST1LjlBCGK/stBA6aG78s/ERiOrcu6km3c0+11xtHOGPBjtv5p
1PibEz7UjzIPn1JAnCvIPReD0WhsWXpGnBEcLoQID1s5TDwCymtZoD2xXK11zu7B
LpPv8Lxw4+1KjQtM4UekdsZJhIVHBqaXuW2JY9UY2MW9sgWPBNzymK8Owu6QIZNq
Dg112utAAwK+zeQxZNPH0SsE3qmXoTWWAO7QFfLaxh26sVYcGQvIPoPyqsS3gr+g
TCJ58JfIgpAlZnRedhJvBiEhmo4ijSwtewbzA7kHxeVeUxltqe+JX/wjjWJ9FE0V
pzsw55niPHNSO5Y3USs6hnA1eQ/hL8kZ/z0WW8+Wwe8gEKt2rzLDm5ya1sJQDM2/
EFPWjI3poss3bLxxrHhkhjOMrJJ8VC56+8NDV9dkOJ+xUH+pLU/2N8u++JOxcLJU
NBGcJSrBGwJB1CCI24U3mqszXSQLS/RG1QndiukYLY+nhZ5+mIIVo5Qo2H6RmDwz
Nhtd8Xf0DU101Gu8mXzfzzShr9KHRPDZl1Pm9VR4B7jdKpJW6AIthRJdqfyj7b/u
TnbGCJcDxC3YyckNRGUR+hiQV288YE4K+UhjdBPzo8RuFs1JZI1712lwiavUxdZQ
OS/c+LM0brp4iGGDfZW1SDCJ7kQe8JQFT71Pwasyy7hTrpJx6Bfh8wzufWA9nFHI
dkTHhkU4SomS0MZHhV8PKSjB0Pg6s4VTDjIIliJld5ViT88nZtVesBkl6XS2E8Qo
snrQ6e7AeH4y4tG+9WIyW5D4L1xz4c6yz/xiGjVt8WJIQ0c9SwL3okyWcySUx1ax
9Lmjer9zQ01trIe6yJS17DChnxXsytOfJB5CD0i26gF+RDFTCf2w5lh5gCVZEgrf
/kgax4310SzfQzM3DdLr66watwtP4ND8X4dyZ/xu9IMKXzOgJQ5oka63ocEmN8A1
1W/MS8hiSXGcESo61x9ok80mx/ArIYqyRE0i40PAH16x1kkDWMemdARhEluewsD7
24E5tCcVbfx08CRdI25hLnALkKqk4E8tXRxLPni7G1tzszjUO4TpL7FKIVQOrZuV
L6knhLMe2kzuNivWGp9K7Hc3CIMqS0frlLxdIJocesVLi9PQir5oy3PM5K17KDoL
jtc5iozF64JDV/158WnnaKJGEaFQI1A7rYMzxXk7RhRnPxFXdHVu0YRpC5kI26Qk
vTP+e8Ic2Nxz/kbN3HLekyoNWbNdJZG9u2CUvJVo0dJrJasb1bjpq7EGjQXy/KKX
GtpSEP/ihM55Y05zaC8qHXWZ9O4b3Juw05glmOvgjilLKKTHxbfg0EHceFG9JZaS
R2BEVxJ0wDOBbEs26LmwzlxTB8cB9N5bp2qK1WjBt760JIEfrgHzI5IMAmLWvm/F
HyjXTY8GjWITP3rSUnDwcqT5xK2ksw2dV5Oyb6XKwTWBQTFMV9NPHg2CG7HIo+P+
9PiqYBdv6sfCNJ+MdOOP2Fom/Bv7nH6eu31baejP7uLf2c+lzx+zuzcfQxfCldYJ
BCXNFp0sH2x9OLxday1wySC+k8OMxtrjwc0vdargwrsTLjJ2iaeMtRgEnCSXpNyy
hESErc7gTlm1w+fxSd8APiy41scDK1d1ElfjBAFHRC3EjyKezsoOock/AaOiaRSP
fpCqmzE++RBq5a4gUvKVAd3ybXwc6jI39m+1oqG6ODuB0H7Hxx+9K3jBkR5F2mxo
POaYEc9jkXvRtlhYOi3O87I3aZvoHOUU4h6i79xSwVq4P+VRpeqQCTxOmZJSx1kU
GhsnMUPd/SRS/7dZhoFt6fcXN3J/+EUGD0ytLH1wjHk0uKUXOYzhlRanJZUBDlyz
raN1yfCbmbu3s9+II33xcj/ywYm0rqSFom1TzgY3rApBfsLvOZdPfr7rbcX94AT4
/HxB2MD42FBSwo0GFR0cKjxD3uaCnGLXHKBFVxRcQ13bXs5MY07b0qrTFblZo3QR
lQHlSeMRpHZfUd7TB6psvXSDsg/3lCj4H7uJGPzBhhwVsTjJts8TBuiSxFpFLvEE
ZDEEqO0wRpe9SiYHYMm6q/6zaMqZEIES0QIdLnnQuCwl3iZ9c6Muk1BAFtHnIDjS
cr3MFkiOhOz47RITEshyEZCw8dt9I83UPpo3BR/mXJW7zJwS+O0cucUMYFcuDCH+
j9ljnUudjMHlfBwfTk35q9Xkx5jWmuT83NbEuurSOKRLbVei1WhBrOhEUc3YmWeu
Yu1QlwmwW6LwWB7WB0um2VDQzkpjgHcqejlqh+R8VXB8snG/dU2E5ebcfYBFYEZt
o/pP26nciWCn0sJ+q+Kqm15QL+JEiTSa3g0+WAGP4U51GZ891v3M1N+g2eMiLXj1
i/DVWNAvUZKVxURZlCnlJMjabwQfy5cN+QV4SRYEuaWRt4b/zRMzgGXa0Xc1CAeu
XMOFJojyEPKtsOU1qgyj
=IkPu
-----END PGP SIGNATURE-----



More information about the sword-devel mailing list