[sword-devel] "Known bad, do not test" modules in Beta

[Nic Carter]

There are a few modules which I can't create an index for.  Notably, BosworthToller and ZhEnglish (there may be more, but I can't remember off the top of my head).  I haven't actually tested many, but I can confirm that I can't create an index for either of those modules.

The code I use (which is common with MacSword, and works for most Dictionary modules) is:

        swModule->setSkipConsecutiveLinks(true);
        *swModule = sword::TOP;
        swModule->getRawEntry();        
        while(![self error]) {
            char *cStrKeyText = (char *)swModule->KeyText();
            if(cStrKeyText) {
                NSString *keyText = [NSString stringWithUTF8String:cStrKeyText];
                if(!keyText) {
                    keyText = [NSString stringWithCString:swModule->KeyText() encoding:NSISOLatin1StringEncoding];
                    if(!keyText) {
                        ALog(@"[SwordCommentary -readKeys] unable to create NSString instance from string: %s", cStrKeyText);
                    }
                }
                
                if(keyText) {
                    [arr addObject:[keyText capitalizedString]];
                }
            } else {
                ALog(@"[SwordCommentary -readKeys] could not get keytext from sword module!");                
            }
            
            (*swModule)++;
        }

Also, if you can't create an index for a Dictionary module in PocketSword, the Dictionary module is completely unusable.  Perhaps I should try to create a module, and if it gets into the while loop and stays in it for a minute or more, I kill the loop off and tell the user it's an unusable Dictionary in PocketSword?


Thanks, ybic
	nic...  :)

On 03/04/2010, at 5:34 AM, Chris Little wrote:

> Are you getting bug reports for them? What sorts of complaints are they getting?
> 
> I might mis-remember the problems with them, but I thought they were actually fairly usable and functional. Their main issue is that some of them are in TEI P4, which we no longer intend to target as a markup format (since we're going with TEI P5).
> 
> --Chris
> 
> On 3/30/2010 8:04 PM, Nic Carter wrote:
>> 
>> Hi all.
>> 
>> Looking at the http://crosswire.org/wiki/Modules_in_the_beta_repository#Beta_Dictionary_Modules wiki page, it appears that we have many dictionary modules that are marked as "Known bad, do not test".  I was wondering if we could move these modules to the "experimental" repo?  That way users won't try to use them and instead find that they are broken and want to report them as so.  Or move them to somewhere where users can't readily access them (both through adding the "beta" repo to their install manager and through the use of the SWORD lib's swInstallMgr->refreshRemoteSourceConfiguration();).
>> 
>> I realise that it is called the "Beta Repository" for a good reason, but I'd really appreciate it if modules that are "known bad" were either deleted or moved elsewhere?  :)
>> 
>> 
>> Thanks, ybic
>> 	nic...  :)
>> 
>> ps:  I'm referring to modules that we know are properly broken.  Others that "sorta work" and just have some minor issues are fine, but those ones are the ones we want to be testing in the Beta repo.  the ones that are "Known bad, do not test" generally have major issues such that we don't even want to be reporting what's bad/wrong with them...  :)
>> 
>> ----
>> Nic Carter
>> PocketSword Developer - an iPhone Bible Study app
>> www: http://crosswire.org/pocketsword
>> iTunes: http://itunes.apple.com/app/Pocketsword/id341046078
>> Twitter: http://twitter.com/pocketsword
>> 
>> 
>> _______________________________________________
>> sword-devel mailing list: sword-devel at crosswire.org
>> http://www.crosswire.org/mailman/listinfo/sword-devel
>> Instructions to unsubscribe/change your settings at above page
> 
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page