[sword-devel] Fwd: Re: bibletime stuff

[Nikolay Igotti]

On Tue, 27 Aug 2002, Troy A. Griffitts wrote:
> 	After reviewing the patch (most of which was just re-indenting the 
> current code), it seems that what you are asking is to have 
> getBookAbbrev first try the normal toupper match, and if none is found, 
> also try a match without changing the case.  Is this correct?  I don't 
> mind this.  Eventually, we're hoping to switch the toupper logic to icu 
> if it is present, and also add an Encoding= to the locale, and this 
> should allow better handling of locales.  I'll add this logic to the 
> getBookAbbrev method (without the 'goto' statement :)  ) if this will 
> help, for now.
 Why everybody hates goto statement? Properly used it greatly improves 
perception of the program (while loop in the same patch would be much 
worse and add unneeded {}). Probably it's CS education....
 As I wrote this patch and if you gonna include it to CVS - some 
recomendation for creators of non-Western locales:
 to make sure that your book is read correctly by Sword - add in [Book Abbrevs] 
entry (beside others) with full book (exactly as it is in [Text]) name set 
to book number.

 Nikolay.



> Joachim Ansorg wrote:
> > This is a patch to make locales, which are currently not working work better 
> > (e.h. russian).
> > 
> > Troy, can you please review this and post your ok or criticism?
> > 
> > Joachim
> > 
> > ----------  Forwarded Message  ----------
> > 
> > Subject: Re: bibletime stuff
> > Date: Sun, 25 Aug 2002 21:54:54 +0000
> > From: "John Being" <olonho@hotmail.com>
> > To: jansorg@gmx.de
> > 
> > 
> >>>Currently it doesn't work out of the box (for the same reasons as Hebrew
> >>>translation, and most other non-West Europian encodings), I would fix it
> >>
> >>if
> >>
> >>
> >>>nobody else gonna do that.
> >>
> >>Does the attached file work better now? I hope it does, because on my box
> >>it
> >>works ok (choosing the books of the list in BibleTime works, at least I
> >>think
> >>it looks like russian :)
> > 
> > 
> > Well not for me - Sword gives bunch of messages like this:
> > Book: &#1048;&#1077;&#1088;&#1077;&#1084;&#1080;&#1103; does not have a
> > matching toupper abbrevs entry! book number returned was: -1
> > Book name is in Russian. I created dirty hack(see attachment) for Sword
> > that makes it working (but slows stuff down for affected locales).
> > Probably it should be in CVS until we'll get better uppercase logic.
> > 
> > 
> >   Nikolay.
> > 
> > 
> > 
> > 
> > 
> > _________________________________________________________________
> > Chat with friends online, try MSN Messenger: http://messenger.msn.com
> > 
> > -------------------------------------------------------
> > 
> 
> 
> 
>