[sword-svn] r3134 - in trunk: include src/modules/common

[DM Smith]

On Mar 17, 2014, at 7:18 AM, Chris Little <chrislit at crosswire.org> wrote:

> On 03/17/2014 03:45 AM, DM Smith wrote:
>> Chris,
>> I thought that the \r\n was part of the module specification. I'll need to verify that such a change doesn't hurt JSword. I don't think it will.
>> DM
> 
> You mean the specification that we define via code? :)

No. By reverse engineering. ;) By the consistency of history. We've always said that it can change at any time. So I'm not complaining.

> 
> I'm pretty sure it's just extra junk at the end of the entry since the comments specifically indicate it's just there for readability (of the data files). Reading RawCom modules with the code change seems to work fine. The only code I see dependent upon particular character looks for '\n'.

Curious, does SWORD strip it when reading it in? JSword doesn't appear to. It also doesn't seem to have any negative effect.
 
> 
> That said, it's easy enough to switch to use "\r\n" consistently, but omitting the '\r' saves us about 32k on a full uncompressed Bible. (Admittedly that's not so meaningful since we don't publish uncompressed zVerse- or zStr-keyed modules anymore.)

\n over \r\n is fine. I prefer it anyway. On occasion, I recommend that people create a raw text module with the flag that puts in markers for verse endings and open it in a text editor to see what is the end result. They won't be able to use Notepad anymore. Not a big deal.

The 32K savings also doesn't affect typical module usage which pulls in a chapter at a time.

> 
> --Chris
> 
> 
> _______________________________________________
> sword-cvs mailing list
> sword-cvs at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-cvs

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4145 bytes
Desc: not available
URL: <http://www.crosswire.org/pipermail/sword-cvs/attachments/20140317/f854e46d/attachment-0001.p7s>