[jsword-devel] Book list order has changed to name from initials
dmsmith at crosswire.org
Sat May 31 11:12:03 MST 2014
Go for it. I'll work the PRs tomorrow.
Cent from my fone so theer mite be tipos. ;)
> On May 31, 2014, at 12:55 PM, Martin Denham <mjdenham at gmail.com> wrote:
> I needed to do a patch release because I was getting complaints so I simply changed the sort order in my local copy of JSword.
> Do you mind if I make a JSword pull request that simply changes the sort order to initials and you can add the compare function support later, at your convenience.
>> On 24 May 2014 13:38, DM Smith <dmsmith at crosswire.org> wrote:
>> I made the change. I'll respond shortly. We can do both. There's a compare function that can be passed.
>> Cent from my fone so theer mite be tipos. ;)
>>> On May 24, 2014, at 7:09 AM, Martin Denham <mjdenham at gmail.com> wrote:
>>> The change to name order occurred 4 months ago with 'Optimized Books, especially for lookups' but I can't see any specific reason for the change in order unless I am missing something. I originally added order by initials 11 months ago while solving problems with books having the same description. Here is the change 4 months ago which changed sort back to name:
>>> Optimized Books, especially for lookups.
>>> Use books directly rather than calling getBooks, which creates a copy.
>>> No longer use BookSet internally, but TreeSet instead.
>>> Lookup now uses hash maps for O(1) for initials and name. Still loops for case insensitive, but only once.
>>> Removed getWriteableDrivers. Deprecated unregisterDriver and getMaxLength.
>>> BookFilterIterator now takes an Iterable<Book> rather than a List<Book>.
>>> AbstractBookMetaData now sorts name before initials.
>>> If there are no objections I would like to raise an issue and implement the change to sort by initials.
>>>> On 22 May 2014 22:26, Martin Denham <mjdenham at gmail.com> wrote:
>>>> The books are now being sorted by book.name which is not the name seen on this screen but is the description. So JSword is sorting books by description.
>>>> JSword used to sort by book.initials (which confusingly is name on this screen) until a few weeks ago. However, there were various changes made including the different sort order.
>>>> Since description is random descriptive text but name encapsulates key text which groups similar books together, could we agree to switch back to sorting by initials?
>>>> I have a user who is quite upset over this issue and claims the order is "complete chaos". I could do the sorting in And Bible but I get the book list very frequently and it would have a small affect on performance.
>>> jsword-devel mailing list
>>> jsword-devel at crosswire.org
>> jsword-devel mailing list
>> jsword-devel at crosswire.org
> jsword-devel mailing list
> jsword-devel at crosswire.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the jsword-devel