[jsword-devel] Book list order has changed to name from initials

[Martin Denham]

I needed to do a patch release because I was getting complaints so I simply
changed the sort order in my local copy of JSword.

Do you mind if I make a JSword pull request that simply changes the sort
order to initials and you can add the compare function support later, at
your convenience.

Martin


On 24 May 2014 13:38, DM Smith <dmsmith at crosswire.org> wrote:

> I made the change. I'll respond shortly. We can do both. There's a compare
> function that can be passed.
>
> Cent from my fone so theer mite be tipos. ;)
>
> On May 24, 2014, at 7:09 AM, Martin Denham <mjdenham at gmail.com> wrote:
>
> The change to name order occurred 4 months ago with 'Optimized Books,
> especially for lookups' but I can't see any specific reason for the change
> in order unless I am missing something. I originally added order by
> initials 11 months ago while solving problems with books having the same
> description.  Here is the change 4 months ago which changed sort back to
> name:
>
> Optimized Books, especially for lookups.
> Use books directly rather than calling getBooks, which creates a copy.
> No longer use BookSet internally, but TreeSet instead.
> Lookup now uses hash maps for O(1) for initials and name. Still loops for
> case insensitive, but only once.
> Removed getWriteableDrivers. Deprecated unregisterDriver and getMaxLength.
> BookFilterIterator now takes an Iterable<Book> rather than a List<Book>.
> *AbstractBookMetaData now sorts name before initials.*
>
>
> If there are no objections I would like to raise an issue and implement
> the change to sort by initials.
>
> Martin
>
>
> On 22 May 2014 22:26, Martin Denham <mjdenham at gmail.com> wrote:
>
>> The books are now being sorted by book.name which is not the name seen
>> on this screen
>> <http://www.crosswire.org/sword/modules/ModDisp.jsp?modType=Bibles> but
>> is the description.  So JSword is sorting books by description.
>>
>> JSword used to sort by book.initials (which confusingly is name on this
>> screen
>> <http://www.crosswire.org/sword/modules/ModDisp.jsp?modType=Bibles>)
>> until a few weeks ago.  However, there were various changes made including
>> the different sort order.
>>
>> Since description is random descriptive text but name encapsulates key
>> text which groups similar books together, could we agree to switch back to
>> sorting by initials?
>>
>> I have a user who is quite upset over this issue and claims the order is
>> "complete chaos".  I could do the sorting in And Bible but I get the book
>> list very frequently and it would have a small affect on performance.
>>
>> Martin
>>
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
>
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/jsword-devel/attachments/20140531/3c053d4c/attachment-0001.html>