[jsword-devel] Heads up Verse change

[DM Smith]

I've just updated the pull request on github for proper handling of verse 0. All tests pass, I've also re-enabled a bunch that were commented out.

Chris, I removed the verse 0 skipping that you added to BitwisePassage's iterator. I added some is*Intro methods to Versification so that you can apply the logic in the front-end (or closer to it.)

The biggest change is that verse 0 does not show up much anymore when converting a range to a string.

I think this pull request is ready.

There may be more to do as a result of further testing or in real-world usage in a front-end, but I think the av11n work is done with this. 

In His Service,
	DM

On Feb 17, 2013, at 3:12 AM, Chris Burrell <chris at burrell.me.uk> wrote:

> Thanks for letting me know about verse 0 changes.  I'll wait till you're done because step has special logic to work out whether something is the beginning of a chapter
> 
> On 17 Feb 2013 05:22, "DM Smith" <dmsmith at crosswire.org> wrote:
> Lots of changes to 35 files (including tests) in support of Alternate Versification.
> You can see it, play with it and comment on it at:
> https://github.com/crosswire/jsword/pull/35/files
> 
> I've tried to make verse 0 not show up quite as much. So Chapter 0 and 1 are both considered as the start of a book. Likewise, verse 0 and 1 are the start of a chapter.
> 
> This has an annoying side-effect. Two verse ranges may have the same "name" but be different internally. That is Gen 0:0-50:26, Gen 1:0-50:26 and Gen 1:1-50:26 are different but all have the name "Gen"
> 
> Will work on that tomorrow.
> 
> Together in His Service,
>         DM
> 
> On Feb 16, 2013, at 1:46 PM, DM Smith <dmsmith at crosswire.org> wrote:
> 
> > I'm going to have to change Verse to take a versification. Was hoping not to do that.
> >
> > The fundamental reason is that we have too much code that allows for Verse to be in a container that requires Verse to be Comparable.
> >
> > I could do a brain dead ordering of book, chapter, verse. This works for chapter and verse, but not for book. Books are not ordered alphabetically, but in versification order.
> >
> > Right now, compareTo is deprecated (to see what needs to change), but it also means that I'd have to remove "implements Comparable" as well.
> >
> > Anyway, there's a patch for this in Jira and it passes all tests. Thanks John for the patch.
> >
> > In Him,
> >       DM
> > _______________________________________________
> > jsword-devel mailing list
> > jsword-devel at crosswire.org
> > http://www.crosswire.org/mailman/listinfo/jsword-devel
> 
> 
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.crosswire.org/pipermail/jsword-devel/attachments/20130217/838f0d04/attachment.html>