[jsword-devel] Heads up Verse change

[DM Smith]

Lots of changes to 35 files (including tests) in support of Alternate Versification.
You can see it, play with it and comment on it at:
https://github.com/crosswire/jsword/pull/35/files

I've tried to make verse 0 not show up quite as much. So Chapter 0 and 1 are both considered as the start of a book. Likewise, verse 0 and 1 are the start of a chapter.

This has an annoying side-effect. Two verse ranges may have the same "name" but be different internally. That is Gen 0:0-50:26, Gen 1:0-50:26 and Gen 1:1-50:26 are different but all have the name "Gen"

Will work on that tomorrow.

Together in His Service,
	DM

On Feb 16, 2013, at 1:46 PM, DM Smith <dmsmith at crosswire.org> wrote:

> I'm going to have to change Verse to take a versification. Was hoping not to do that.
> 
> The fundamental reason is that we have too much code that allows for Verse to be in a container that requires Verse to be Comparable.
> 
> I could do a brain dead ordering of book, chapter, verse. This works for chapter and verse, but not for book. Books are not ordered alphabetically, but in versification order.
> 
> Right now, compareTo is deprecated (to see what needs to change), but it also means that I'd have to remove "implements Comparable" as well.
> 
> Anyway, there's a patch for this in Jira and it passes all tests. Thanks John for the patch.
> 
> In Him,
> 	DM
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel