[jsword-devel] Versifications and key absence
dmsmith at crosswire.org
Tue Aug 6 04:53:21 MST 2013
Couple of thoughts.
When we only had the KJV versification, it made sense to throw out non-KJV references as invalid.
With v11n, we have v11ns w/ just the OT and those with OT and NT. There are none that have only the NT. Though you'd think that a Greek one would have an NT only versification.
This explains what you are seeing.
There are two things that are needed (which I think are in there):
A check to see if the module contains a verse.
A check to see if a verse is in the versification.
I agree w/ parsing not failing except when unparseable. I do think that it no longer complains about chapters and verses that are not in the v11n. So it is only an issue w/ book names.
Regarding parsing, I think it should use most book names, not just those in the v11n. But should it be all? Should it always include the apocrypha book names? If a user mistypes a book name should it get a hit on an apocrypha or only on the canon?
One of the things I think have been needed for a long time is a parser that doesn't try to guess the book name. This would be for osisID/osisRef. Most references that JSword deals with are encoded within modules.
Aside: Today, we do a lenient parse which fails on osisIDs. Upon failure, it mungs the osisID and re-parses. If we had an osisID parser, we'd reverse this.
On Aug 5, 2013, at 12:42 PM, Chris Burrell <chris at burrell.me.uk> wrote:
> I'm having a strange behaviour due to how our versifications are implemented.
> If I'm looking at the OSMHB module, then looking up Mat 1 gives me a NoSuchKeyException
> If I'm looking at the TR module, then looking up Gen.1 gives me an empty passage.
> STEP shows a message saying the module doesn't cover the passage in the latter case. The former case is tricky, since the reference could be anything at all...
> What are your thoughts? Ideally, I'd want to say "invalid" when the reference is something completely unparseable. However if it's simply not present in the versification, then I'd probably want to say that module doesn't cover the passage.
> We get similar issues for Apocryphal books. Any thoughts?
> jsword-devel mailing list
> jsword-devel at crosswire.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4145 bytes
Desc: not available
More information about the jsword-devel