[jsword-devel] Fixing PassageTally.trimVerses

DM Smith dmsmith at crosswire.org
Wed Sep 5 19:12:54 MST 2012

The method should be deleted. It should not have overridden its parent. The only harm is that it raises events too often.

In Him,

On Sep 5, 2012, at 2:43 PM, DM Smith <dmsmith at crosswire.org> wrote:

> I might have time to look at this in a few hours.
> IIRC, raiseNormalizeProtection is a local counting mechanism that will prevent events from being fired.
> So if A is relatively small and fires an event, but B does many A (e.g. iterating a list) then B might want A to not fire each time but once.
> -- DM
> On Sep 5, 2012, at 12:29 PM, Chris Burrell <chris at burrell.me.uk> wrote:
>> Hi
>> Any reason this overrides its parent? It's behaviour is (almost) identical to AbstractPassage (apart from the raiseNormaliseProtection - which I'm not entirely sure what it does).
>> Please note, I've set up another pull request to fix the fact it was returning count+1 verses.
>> Cheers
>> Chris
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel

More information about the jsword-devel mailing list