[jsword-devel] Re: Patch for web installer

[Joe Walker]

I'm sure I replied to this from in mutt, but it hasn't got back here yet.
The short version is "applied". I assume my comments will be along soon.

Joe.

----- Original Message -----
From: DM Smith <dmsmith555 at yahoo.com>
Date: Fri, 20 Aug 2004 16:43:19 -0400
Subject: Re: [jsword-devel] Re: Patch for web installer
To: Mark Goodwin <goodwinster at gmail.com>, Java SWORD Developers
Mailing List <jsword-devel at crosswire.org>

The code looks great. The only thing I noticed was that there were no
Thread.yield(), which Joe did to fix the selection redraw problem. Is
it needed here?

I also noticed that it creates a second tab (which I think is a really
cool behavior of using properties to allow different installation
sites). Do we want both an FTP tab and an HTTP tab? I tested it on
WinXP SP2 and it works great. And it seems much faster than FTP. My
guess is that it is because it is a single get operation of a
compressed file.

Mark Goodwin wrote: 
BTW; there is one issue I am aware of; because the zip contains the
..conf file, it dumps it in the module data directory. This file is
redundant anyway because a copy is created from mods.d.gz
I think that this is OK. At some point we may want to remove the
copying of it out of mods.d.gz.




On Fri, 20 Aug 2004 20:43:00 +0100, Mark Goodwin <goodwinster at gmail.com> wrote: 
This patch is an HTTP sword installer. It's closely based on the
existing FTP installer; we might want to create an implementation
superclass for some of the bits; I didn't. This installer works on all
of the test machines that the FTP installer failed on. HTH. MarkG
_______________________________________________ jsword-devel mailing
list jsword-devel at crosswire.org
http://www.crosswire.org/mailman/listinfo/jsword-devel

_______________________________________________
jsword-devel mailing list
jsword-devel at crosswire.org
http://www.crosswire.org/mailman/listinfo/jsword-devel