[jsword-devel] Bible Desktop application title

[DM Smith]

I have put the name and version into desktop.Msg.
I added a few static methods to that class to get the title and version 
string in the various ways the program uses them. And I removed getName and 
getVersion from jsword.util.Project.

And you are right, the project.properties file won't be needed.

I also have created Msg.properties for each of the Msg.java in bibledesktop.
I am also working on the buttons in common/config/swing to i18n the 
mnemonics.

I also found a couple of bugs where a base class constructor calls 
initialize(), but the derived class has initializers for the member 
variables. This is the basic reason, I have been moving initializers from 
the declarations and into the constructor or into a separate initialize 
method.

Joe, I hope you don't mind, but I have been following your lead and renaming 
jbInit to initialize or init in the files I am touching. I saw a comment 
that this was a nod toward JBuilder. Is JBuilder useful?

Joe, since you are busy with your release, I am collecting up the changes. 
Let me know when it would be convienent for you to get a patch.

I have decided to use Yahoo mail instead of HotMail. Hotmail always is 
adding some kind of advertizement and it breaks the threading in the 
archives. Yahoo does not do ads and it allows me to use my pop3 e-mail 
program (so hopefully the threading will work) How do I go about changing 
the jsword-devel subscription to use dmsmith555 at yahoo dot mail?

Joe Walker wrote:
>
>DM Smith wrote:
>
>>I mentioned earlier that JSword is embedded in the splash.png file.
>>I also found that it is in the following files as the program's title.
>>.../bibledesktop.desktop.DesktopActionFactory.properties for the "About" 
>>action's tool tip.
>>.../jsword.util.Project.java
>>.../resource/project.properties, which is used by Project.java
>>
>>I took a look at Project.java and how it was used and it seems to be 
>>intertwined with both jsword and bibledesktop, but mostly used by jsword.
>>
>>I am thinking that bibledesktop should either:
>>have its own Project.java, or something like it, perhaps derived from 
>>jsword's Project.java that redefines strings that should be redefined.
>>or
>>split Project.java so that the functionality is appropriately located by 
>>Eclipse project.
>
>That sounds like a good idea.
>I would guess that we might well discover that BibleDesktop.Project and 
>JSword.Project don't overlap that much, but we do need 2 things I think.
>
>>Also, the title needs to be internationalized, which means that the 
>>property file that contains it should be read in as a ResourceBundle.
>>
>>In project the pattern for getting properties is props.getProperty("key", 
>>"default"). There are two shortcomings with this.
>>First, the default may need to be internationalized.
>>Second, it is not a part of the ResourceBundle interface. The whole notion 
>>of a ResourceBundle is that there is a default property file. So this form 
>>of getProperty is not needed. So, if we convert the project.properties to 
>>a ResourceBundle so that some strings are internationalized, then this 
>>form of getProperty for the other properties will need to change or the 
>>property file will need to be split into two or .....
>>
>>
>>Anyway, any thoughts on how this should be changed?
>
>The current way isn't good I agree. I suppose that the app name is just a 
>user visible string just like any other, so perhaps we should read it in 
>using Msg?
>I don't think the other keys in project.properties are that useful so we 
>could probably get rid of the whole file.
>
>Joe.

_________________________________________________________________
FREE pop-up blocking with the new MSN Toolbar – get it now! 
http://toolbar.msn.com/go/onm00200415ave/direct/01/