[jsword-devel] Patch for more i18n

[Joe Walker]

Hi,

Thanks DM - the little I've seen of this patch (set!) looks good. I've 
been busy at work this week and a little stressed because there has been 
a lot to do and get sorted out. I hope next week after the release 
things will be a bit calmer!

Joe.

DM Smith wrote:
> Attached is a patch which does the following:
> For every change in the jsword project that is now being migrated to 
> common or bibledesktop, I have made the change in both places. I only 
> tested it in jsword.
> 
> ActionFactory
> added createJLabel(String actionName) to use an action to construct a 
> JLabel. This seemed reasonable since we needed to internationalize the 
> mnemonic that was being attached to labels.
> 
> SwordInstaller
> fixed a bug where File.separator was used instead of '/', which it used 
> to be. This caused a failure in doing downloads. I replaced all 
> instances of File.separator with '/'. I think that File.separator is not 
> really needed anymore, but was needed in earlier versions of Java.
> 
> Passage and its derivatives:
> Changed clone to not throw a CloneNotSupportedException. Changed a 
> comment that expressed uncertainty as to why a re-declaration of an 
> abstract method was needed.
> 
> .../view/swing/book
> Added BookActionFactory. This differs in implementation from 
> DesktopActionFactory in that it does the reflection bit. I was getting 
> tired of repeating code in the classes that used BookActionFactory. I 
> tried to move the method to ActionFactory, but found out that the 
> derived class (BookActionFactory) is not used to determine whether a 
> method in the same package is visible. I didn't think that we wanted to 
> make protected methods public, so I did not pursue putting the method in 
> ActionFactory.
> 
> Also added 
> org.crosswire.jsword.view.swing.book.BookActionFactory.properties to 
> resources.
> 
> Changed DisplaySelectPane, EditSitePane, PassageSelectionPane, SitePane, 
> SitesPane:
> Internationalized all strings and mnemonics. (into Msg and 
> BookActionFactory)
> Rewrote initilization to eliminate unneeded member variables and make 
> the code more readable/understandable.
> Enabled and disabled actions instead of the buttons.
> 
> SitePane
> changed constructors so that only one did work and the others called it.
> 
> SitesPane,TabbedBoodDataDisplay,TabbedDisplayPane
> Turns out that when adding a tab to a JTabbedPane, the first argument is 
> supposed to be the title and the second is supposed to be the panel. The 
> code had it backward. It worked as long as the second argument was an 
> object that was not understood as a constraint by the current layout. So 
> I changed the argument order. Since I just focused on java/swing... 
> there probably are other places that this problem occurs, such as in 
> common/config/swing.
> 
> Desktop
> Finished the externalization of strings.
> 
> Changed the -mx argument to the running of desktop from 256 to 512. It 
> was running out of memory while indexing a Bible. Only did this in 
> jsword and not in bibledesktop.
> 
> What remains to be done before starting translations of resources:
> Create property files for each implementation of MsgBase.
> Internationalize the mnemonics used in common. (Search for setMnemonic 
> to see the problems)
> config.xml contains help text that needs to be externalized. I am 
> thinking that the file has a key that is used to do a lookup against a 
> MsgBase.
> Figure out how to internationalize the names of books of the Bible.
> There may be more, but this is what I am aware of.
> 
> _________________________________________________________________
> Stop worrying about overloading your inbox - get MSN Hotmail Extra 
> Storage! 
> http://join.msn.com/?pgmarket=en-us&page=hotmail/es2&ST=1/go/onm00200362ave/direct/01/