[bt-devel] close button on bookshelf dialog

[Martin Gruner]

Hi Jaak,

I didn't notice the button removal back then, sorry. So I might be too
late, but it doesn't change the matter of fact that having a close
button is sensible usability design for PC software. I don't see a
benefit of conditional compliation.

Regards,
mg

Am 26.06.11 21:38, schrieb Jaak Ristioja:
> Dear Gary and Martin,
>
> I reverted Gary's addition of the close button to the Bookshelf manager
> also because it was actually more-or-less a revert of my removal of the
> close button back in September (commit c277ce) even before 2.8 beta, so
> this has always been in the stable-2.8 branch. I even documented this
> feature in the ChangeLog and announced the bookshelf manager redesign in
> the 2.8 beta release announcement. You and Martin released Windows and
> MacOS binaries of 2.8 beta. I might have bad memory, but I really don't
> remember anybody objecting to my GUI redesign back then. So I've been
> very happy about the redesign ever since. And I still am.
>
> I'm very sorry, but you're just too late trying to take this up now.
> Where were you when the discussion should have taken place? :|
>
> On 24.06.2011 17:09, Gary Holmlund wrote:
> > I believe a close button
> > belongs on this dialog for usability reasons alone, even if a close icon
> > is in the upper right corner.
>
> I disagree. We should strive for simplicity and not duplicate such GUI
> functionality (the KISS principle). Such waste of screen space harms
> usability, especially on small screens (e.g Meego devices?).
>
> >> Also, Meego does not put any window icons on their dialogs. There is
> >> no work around for closing it on Meego.
>
> According to
> https://meego.com/developers/ui-design-guidelines/handset/designing-your-application
> Meego appears to have a "close" button. Please tell me if I
> misunderstood that text and those figures.
>
> The current Bookshelf Manager GUI works well on Windows, KDE and Gnome
> 2. Gnome 3 has a bug which prevents it from working, so this is not an
> issue we must work around in BibleTime. Has anybody even run it on
> Meego? Any other platforms with problems?
>
> This is not a bug. This is a feature introduced more than 9 months ago.
> IF and only IF there is a serious reason to re-introduce the close
> button, it should be done using conditional compilation (e.g.
> #ifdef/#ifndef). The default should be to compile without the close
> button.
>
>
> God bless!
> Jaak
>
>
> PS: In the future we should probably also discuss about simplifying the
> MDI stuff and everything related to the subwindow toolbars.

_______________________________________________
bt-devel mailing list
bt-devel at crosswire.org
http://www.crosswire.org/mailman/listinfo/bt-devel