[bt-devel] refactoring

[Jaak Ristioja]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Olaf!

On 04.07.2010 19:16, Olaf Radicke wrote:
> == 1.) ==
> 
> In frontend/display/cdisplay.h i have found two classes in a file. is
> that clean?  here find it differently:
> http://devel.bibletime.info/wiki/Programming_Guidelines#Headers_and_implementations
> 
> 
> == 2.) ==
> 
> The same in Flie
> frontend/searchdialog/btsearchresultarea.h
> 
> You can find there: 
> 	class BtSearchResultArea, 
> 	class StrongsResultClass, 
> 	typedef QList<StrongsResult> StrongsResultList, 
> 	class StrongsResult
> 
> what is the reason??

One major class per file. I guess its to keep the number of files to a more-or-less
reasonable minimum.

> == 3.) ==
> 
> Which means "Bt" in the name of "BtSearchResultArea"? It this meaning
> "BibleTime? Why you doesn't use name spaces? like this:

Yes, the codebase is not high-quality... yet. We try to improve the code as much as we can.

> BibleTime.GUI.Search.ResultArea.funktionOne();
> 
> now you can cut the name:
> 
> using BibleTime.GUI.Search.ResultArea
> 
> an write:
> 
> ResultArea _ra;
> _re.funktionOne();

I guess you meant :: between namespaces.


> The name of the typ "StrongsResultList" is not really shorter then
> "QList<StrongsResult>" (three char different). So, what is the profit?
> 
> 
> Same name for different things....
> 
> class StrongsResultClass
> class StrongsResult
> 
> Both are classes. Not only "StrongsResultClass". I think, that am no
> good idea. The name should say that the class is. "Class" is no
> characteristic of a class. So which is differentiated of StrongsResult
> and StrongsResultClass?

After receiving your letter I started refactoring the BtSearchResultArea files. I am not
familiar with that code myself, but I agree that at least StrongsResultClass should be
renamed. Any suggestions on the name are welcome.

Thank you for pointing out these things. As has also been said by others, the original
BibleTime code was written by people with not much C++ and/or programming experience,
hence it needs a lot of refactoring. Unfortunately, we are a bit understaffed lately.

Jaak Ristioja
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)

iQgcBAEBAgAGBQJMMM6bAAoJEFqwhAoGc/hvPfY//3re92tS1F4PTqTE9M3S8KSf
QH0dNImKO/x1Hrgqvn9YSkSEw/B/ISTYeoCbtHXcEL6lNQwipnzW9jZZp9sYip3j
8If4XrIoN9vTijiyJdsWSyuMJuWfinwenC8NKXSK3Nk4LMeuFqT/+J8stngU5UPz
ZM5w6RvsaDplAAzW2oP/xw+fQPqoW1x10u51iCkP47RObECcUrCP+7cGv44gxIVS
4wO87GObP3uZpna9Y8rMRx8JrAuiJw2jPgb0jbphoqslX4x+4+zlw2QLCuW2UA03
E0NVK3cFFNztSIH+QPLnwVWhCFv3m2R0tW1egAE6YKdkgxFZZSTM6Yw1lJCwzHEl
S25J9GwPcfP8MxXMONsN140x6Cl7jmQh8V85Qq/rx5rx/wAPFCMy1gRcmEUCiXlN
rDgJrDWMlnPkfasAGs2RQGRLmSzldbLNyXCxDu7BAqMX+8I/uMf2DdV8LUS9+3a9
Gsxf3zpz5xrfyiEyYLEevTQ5YYlsvH2WxkvDrAv8olIlBUrS3FOKEgMXoin1EWRM
yd86RuMc807xbj9+K7NDJxKiY9f4ydogTOvgiSEY15Mk/B96pNdGpsRp10NlQgR8
qiKLwG4tbzgvBwy9V8rYNdT0rf+aSkvI+jriqUY2nRzmWQzbyn58TAlOcdaeQ9hm
79UMJc0YKsy+BsIQhxQjVZGpW4riQ5xc5nuqogBBu0F7E0SHHwvnlFmqX2RaNyt8
3hGER/ZCR+GAiJSZo+forAPNQO8jLT+weoWRUB2LqDb1qt12uL6By0He99DzazO5
8T+bDkfReLSMXi2FL3rMjQjg0W7ThcAhXrG6LovDnKuCMZpmZwyrzfBv2+r/D3mp
YWFZdmJ88KbIQAK6GwCW/9gua4vSV+5iidkjsAIGZmKclHdDsJgUh+S90+uUJKSO
8sekbEMYcsft4HCwZUWP3Yl7wUkEh+hyYj0wIxpnHzMbgH60iFAozaNv5XE6l/KD
XxHbthcBPHPbkAQoHLWhzqqVE8AXAQs6P92XRyRjISG6u7Gt2iJmX7akyXCZjBbf
MWLwWFnbcAnZdvlVBjxZZQSzP0muaCrCcPURH7aBQy5mfqgcgZ61A9Xf2AE9yENt
P9RGwoUHHJ9cx6K29940Z18YHmNpgnyYFPeCD841C2kYRrtYCiVw+1pqzycpbe1f
HRhuescBX+q37/2gHDUic4gaV3rtr0wMxwwdZm1/HD/0mYjubgFKxZymqsaiVwE6
QOjPpFP+GvJX7QGDEHh3ZFy++Cykh+csOxLGYNVCH/WMUTLJ7dTnXJObm/pYfRo+
gWA0pEHVQlEKeHXO8wcGJFoZubD9+0kH8hGcxxoIwqk4j/1PcH4jXdpkS+2uwwMV
ZOOM1h1ge0R7KMpvRdQQQqU4LvxCXtIIi+K1wj5P7NBjLRGgXSL1MJJxTGfGuArg
4RhdVValki3DkbnUuKTR9tkoznx7Yyks5WJ83+i1hrCwHpV6cJlui3rgvb9AhIwa
ID/T2GIUn2K1OIh8K5g6bQuXA24RDsGN4dwWCZ8kIr9LwF9IoiL2N4sjc4xSWxlW
BzYa8Uu/kZJg6XjwkpHD/M3OniF6e2FP3NJBnst2j+gQMl2fnLHoHiYeaZAqT51n
I4ZVytWe+FIkwTUdGzvjdeKrcHn0yV5Zp+T0dREgCSvFdtbHGPljvg1GxeRIgmud
+m34EpRzQF8Fzw185vUnJO0wDq5wtjZ/djf1Aq+oBwl/oXpxX1cDbG7xw07KUeb1
iakDLbSnrvgnTsKlPAHtPZ3oBN8gdo3Xbqg6FyUwWNrmP8jDapHQ1RAfooG8VTbD
XRclRLBI4LAdlKzZ8e+hvzg2cYoKUoHVZeb0oiC6NLD3+S6t8W+BHpuIHi6sVnFk
eqmg34FH2fFn2BHMA7dpZdYtB3Veayn+t9A8NnzclYGRcK3XOwj5nHIe3/HVBKA4
e92Ykplf4a/gW+uWwtV9FmIuuJSUrvQlnX0bZWYtKBqd6lYZsxYnevtiYcSzAGny
DK4W/4PrX5E6wF6pNdmU5tOT3XwKzeXu0huYjeCwjAzcei1bro37PU5Vi89fhH2P
BaLKzofK7H4+5NUxf5PTvLXuQOP0SbjGBu+Ke+Xv74p/1tCzAPaSiAGoTgNGpT2T
K3k3Ki9QgiGaYSk/S/HCzyAdfyU+7wT5CR0ShK1yzwavfh2+1EVDojb2X98VdlDc
q1Om7TBORmjQUBO7YDFSYpsfJyiiEUE0FOy71IyVmrLhAZeNdv5QfYhPJaHTYG4E
yBIntAIxE3hBJiIyA/G0rPAjFAMd0I0zA6nBlPUjdmKo72ikKwdu4NTinGG2nVE3
SD584M4NY8rIMKpp+JXVRLBP+WUV3TYZmi7Q7dBjoedMGrpToq5uq9T34cOYAAwT
m3nunjUl1UgSkyVPKK/WIalb0pEwdb46+xayOB68E3I77/mh1hg1GikST2Os4Yi9
A2mIvSoZS6Yav5Gdqakc1D1DRog3I0fW+pK2Jx0yA8/+eBlfO2IihfeHRystrQQ2
KR/bWvFoBIrooghh95BQWgsR/CfCmfz4gOpJh9Pg5DE3k4zKlznzRqvsvwHNcwOt
InD0qE9grYWOaSped3OpuIZ58QNNegmjBSgZ9cKiuPxcM9DxaQADf+LsImwW3I1k
j7DFyjHu2yMPB1RbVCzIXQ/Jee4Bc2I4ZLFIy47yjyioikEdzXoc8VLitp5qAOlt
PRAtA13KzzS/W+mrOBRz
=2WJe
-----END PGP SIGNATURE-----