[bt-devel] refactoring

[Olaf Radicke]

Hi!

== 1.) ==

In frontend/display/cdisplay.h i have found two classes in a file. is
that clean?  here find it differently:
http://devel.bibletime.info/wiki/Programming_Guidelines#Headers_and_implementations


== 2.) ==

The same in Flie
frontend/searchdialog/btsearchresultarea.h

You can find there: 
	class BtSearchResultArea, 
	class StrongsResultClass, 
	typedef QList<StrongsResult> StrongsResultList, 
	class StrongsResult

what is the reason??

== 3.) ==

Which means "Bt" in the name of "BtSearchResultArea"? It this meaning
"BibleTime? Why you doesn't use name spaces? like this:

namespace BibleTime 
{
	class SearchResultArea(){}
} // end namespace BibleTime

and then consistently...

namespace BibleTime 
{
    namespace Search
    {
        class ResultArea(){}
    } // end namespace Search
} // end namespace BibleTime

or then better...

namespace BibleTime 
{
    namespace GUI
    {
        namespace Search
        {
            class ResultArea(){}
        } // end namespace Search
    } // end namespace GUI
} // end namespace BibleTime


BibleTime.GUI.Search.ResultArea.funktionOne();

now you can cut the name:

using BibleTime.GUI.Search.ResultArea

an write:

ResultArea _ra;
_re.funktionOne();

== 4.) ==

The name of the typ "StrongsResultList" is not really shorter then
"QList<StrongsResult>" (three char different). So, what is the profit?


Same name for different things....

class StrongsResultClass
class StrongsResult

Both are classes. Not only "StrongsResultClass". I think, that am no
good idea. The name should say that the class is. "Class" is no
characteristic of a class. So which is differentiated of StrongsResult
and StrongsResultClass?

== END ==

what think?



greetings,

Olaf Radicke
(munich/germany)