[bt-devel] About window size is too weite
Olaf Radicke
briefkasten at olaf-radicke.de
Tue Dec 7 10:22:00 MST 2010
Am Dienstag, den 07.12.2010, 09:28 +0200 schrieb Jaak Ristioja:
> On 06.12.2010 19:19, Olaf Radicke wrote:
> > here is my proposal for solution as patch...
>
> It's a very good idea to use a tooltip for that. I like it. :)
>
> If you want me to accept your patch, it needs two minor modifications:
>
> 1) Add the title label (e.g. QLabel *m_title;) to the private fields
> of BtAboutDialog.
"m_" it is meaning member but it is not a member of this class. it is
local a variable of a function.
> 2) Move m_title->setToolTip(tr("Build: ") BT_VERSION_BUILD); into the
> retranslateUi() method. Note the usage of tr() and the extra space after
> the colon.
>
> In addition, please send us the final patch using "git format-patch" so
> that your credentials would be listed in the git log. Thanks!
Us http://sourceforge.net/projects/bibletimeofolaf/develop with
cherry-pick, and do as as you like... ;-)
Cu
Olaf
More information about the bt-devel
mailing list