[bt-devel] About window size is too weite

[Gary Holmlund]

On 12/06/2010 11:55 PM, Jaak Ristioja wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 07.12.2010 09:28, Jaak Ristioja wrote:
>> On 06.12.2010 19:19, Olaf Radicke wrote:
>>> here  is my proposal for solution as patch...
>> It's a very good idea to use a tooltip for that. I like it. :)
>>
>> If you want me to accept your patch, it needs two minor modifications:
>>
>>    1) Add the title label (e.g. QLabel *m_title;) to the private fields
>> of BtAboutDialog.
>>
>>    2) Move m_title->setToolTip(tr("Build: ") BT_VERSION_BUILD); into the
>> retranslateUi() method. Note the usage of tr() and the extra space after
>> the colon.
>>
>> In addition, please send us the final patch using "git format-patch" so
>> that your credentials would be listed in the git log. Thanks!
> Actually I just found out that Gary already silently committed a fix for
> this yesterday.
>
> However, it would still be nice to have BT_VERSION and BT_VERSION_BUILD
> as separate macros, and a tooltip for m_versionLabel to show the
> BT_VERSION_BUILD in full. And I think that since people reference git
> builds using the left part of the git hash, we should use Qt::ElideRight
> instead of Qt::ElideMiddle.
>
>
> Blessings!
> Jaak
I mentioned in IRC that I would do the change a few hours before I 
actually did it. Also, I missed the fact that a patch had been 
submitted. I won't do anything more until it is clear if we will use the 
patch.

Gary