[bt-devel] [Fwd: Re: Your changes in CVS]
Jaak Ristioja
Ristioja at gmail.com
Tue Nov 17 02:12:45 MST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I didn't notice Martin also sent this to the devel list, so I'm
forwarding my reply.
- -------- Original Message --------
Date: Tue, 17 Nov 2009 09:53:36 +0200
From: Jaak Ristioja <Ristioja at gmail.com>
To: Martin Gruner <mg.pub at gmx.net>
Subject: Re: Your changes in CVS
References: <200911170752.43708.mg.pub at gmx.net>
In-Reply-To: <200911170752.43708.mg.pub at gmx.net>
Martin Gruner wrote:
> Hi Jaak,
>
> I just noticed that you made several commits to refactor the codebase.
>
> Just one day before a final release, this seems inappropriate to me. If you
> cannot _really_ guarantee that they don't break anything, please roll them
> back and apply them after wednesday again.
>
> Regards,
>
> mg
>
Hi Martin!
After receiving your letter, I re-analyzed all the changes I made after
r1800 reading through the diffs line-by-line. I have also tested those
changes (which can be tested at runtime) quite thoroughly before
commiting them to SVN. And the code compiles (at least with Qt 4.5). If
given that the documentation I have for C++, Qt and Subversion are
correct and the Qt Creator + cmake, svn and ack tools work as specified
then I'm very certain I didn't break anything.
Given some healthy doubts introduced by receiving your letter, I still
feel about 95% certain that nothing was broken. The main reason for
those changes was to ensure that the code is actually correct and high
quality. Some of those changes incorporated commenting the code properly.
If you have any questions about the implications of those commits, I'm
ready to explain all of them.
Regards,
Jaak
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)
iQgcBAEBAgAGBQJLAmkDAAoJEFqwhAoGc/hvS8o//2AWKahYDM5ZiOPQgRG/cZAz
fFcG26EkwiyJ17uBYp2P4lI0kM96NDPIuuz4qskyi3cbYEeEVjt9Id+Q16oOcWaH
4Nt+AwHyFJHy0dq3wWcMBsK4SyIFSu03m+3bVoA3jhvRmVpxkD1qQxHg1j4hyKwt
GwOpVUhCt6IH+K+l0SGmUB54nmNpYeG9hFGxq5Zb9djonM7SyGL23de2ipyl4tz+
zJiqZQuaZu6uBVK68IZwWowaKr4NcP7/dGHcPjQ2D2sJIyi1YOHdeDWf86f/SOnW
zyE8lGjpXyb7rMKdGxy6Y9ONA+sJLv03YQer87U1mUL5/FyP4xBrg3fcfVOySBoj
55x2pbnMfbOykvuvvKWsjes5qiYlhezPTjPSbkAi7SGKT8mXnr1LXyB7xMu4uZlV
KAooBn5BLkDITUlQCg6a6wvErvH09HAe+x9c+SIutld5Zl+zESuhx2su3B531yBg
ox5HaLDfCqo43S/NOeDwn24DXR80FpXj1HgJbdbJEVN1NDFbFlMtwq99dZy11mFm
+tfi9sfsNE284jCgx+nDMu+uJbl736xd4QsaytbtEcUOQ6uYNThK6Hw98vErGA9i
HUpwxMFcD5pa0O6fAHrh/RMyC+7p2q+73J71vEfiH5LSOiLil84BlZkzU8lYE0hh
Y3J2ZxdcrUk6BiiH40XCW3Xr3G3bqKuz/ivOZ45uQRAqp6nggWct1P/tcdNDD1eU
0e9QGMkJBkAiAEUNAsgZgK3HjwU1otEuxOe2EAQUMuJnLvyx8wKnOYZwIvVko46w
HtEMPG/LFFsANRpLvg0rZ2dKeykERe7peEA4D4h3QTv7kMHyxLbL9H2qY6et28Uk
nW7gOJNX6JyonRgkToc3mFfpnsCGb+m04ADUydZqAiXMsXRuttcI8OESuhFgBIvb
iD1gGEKua3GZbcrjw4NOR6GDps+jJxyKz6qXmCmC/2JQZijCwFfg8weG6g4A14vh
4hRFWkFLNQNTfghSLKcWzjae4HurBFr7VZA+UeAIyTwHLKILH+ewQfxU05AKZpDB
HizBJQQtVCh6pebAXC7otjWfGcI/yEVqfFNJ0L2mWT7lOm9AS3qXgGVXEkhdbZxZ
W2il6GEm4OT9Z+Z7JxLekdffT6bM/E9egX7fnMOOKwkIDQTe+ND1JistPx6FNy9r
i28iICsxZHkor/zICF/MNyH23qDQvvDYop1YmND6N0ueNsp6dy9nBn6h21nGd4h9
Eh6YCNY6CmiEjWDhvum5vRbVxNHjVbiW0OmDl5503TYG3H6isDRHBKn6nLetfCXw
3u/7JL3pQjLOGFUaSEgeQhpB0KqM3dnBefP2tn5KBfAmYSDmynXIEZqDFXD//IHr
avffMdyzjOD5GIv0/pkN7oeUZZKupPq0wDn+nF1py/oXBzC3fRWRwr4b7hghwfr/
Ko/ubOdE5et+0warkte/sFcPUwi/FeiuvoBY6lGMbKxUEp6/5f0p+fy+BeNEIZ5I
OTlVWZn3BwYY+OD6Jginlyzg1xiTKm7gzwHVlq4R/AE+m1682y+VZt/c1/uhD5mW
y7/WENi6Chbh5yyKX2VZjGILVhVSmMlQDWhWL7uvtVe8HxcCysZDa3S6zYzqneuB
rLSELxdFwy26m+UgOAcYPbKSn2SqZ9DOt0xrLb8iF9mucAKYPOnPL+HvNX2AWm3V
GvM02KZ2Pi4/jjBgHvAAMGPdnVhRb/G1oM4LqqS7Ox5v3RbSJ16nqHiGPJcKP7eJ
Meb0YyDi4M6k6EZBrzPRG8IHmc0BPFAil9A4vaiSSAsKbIPlYivVwKPDcTj+nEoX
X3ceqIhLZA5thKD/qVmkb8Fd+xBfX+j7+mj5ZIYAchfdps6qsu5poTn4CNjTMTyK
vIiJ/1MOvfMyNmn48YaDgHVtBLRdwGtAD5HQv/iwblk98evZ1ZhOB6qA7JblEu5k
W1fcP9LoLekmUsySbDLqaqiwCn6pwhxEz3G6UTbzvDbd5Ume1ZZMkmBXCgLT6QOw
XWJzA6UpcH0WxdrOYyLq4ynlCAPs11PVhZAmap3UIg0YUUpnNkcp5IbND5aYr/87
8TRIn3FIWjm46+0yrji7SuASOsHwLPqoEDKIXl2wzySAcLowm4G08xNFT2Bau5fP
YtdntlrDoXXt11geGPf2IVJccW65FTv9mTi2nyjZrrEyhPzIk7W2hGZsQRSLQjXI
lScIAvL9WzSQWaZibXcMPZGquUb/fhgCi55tllVHmxeH3Sd3CK7yZruUBpknKoTK
R0mBwzICjzwJkFfAXdMg3fnam5aALXXbERyh899R7ZeDlZON6uZlZ8HzgSEQBZQr
jGUaIkSAHFJ+5+AVoglvjYgnb+ghkAzS6sbMP4SLuaGFKz95DP0xVP7nFuDeYL1R
lClMZNT0jFIjg91HschqihmZbpw9ZPGvzGPD8w8ztn+VxiGTS0ai4psxTVh9OvHl
fTB9jts3LttGUlKqptInVF8sR+ecREuoabPDjNERV5CCAuQ5i4LUMSg4yHRf64Qo
sMEWK1fP0erw3gc8iK4Sap9rSP4o3JqXUjhTqwZaePyYJoDce5sndO1GL9WmA4Lq
Gwu1vgcw9TfRewHGY/uNn2Ch7BIjVuhpLZn7x/Di6HEP9VPCxqRy2Hvt58nmvqQV
7Frk8YfDdxdqI8zX0dgGEkRPTgL16D0Wk2B7HXQ7n4KxCkJcaURww7sOHaMw3JQZ
O0J64N3KkXa9N1wWvR36
=+I00
-----END PGP SIGNATURE-----
More information about the bt-devel
mailing list