[xiphos-source] [crosswire/xiphos] d9ddf9: fix: replace fixed 1023-byte stack buffer with GSt...

Devon Kirk noreply at github.com
Fri Jun 19 09:46:21 EDT 2026


  Branch: refs/heads/master
  Home:   https://github.com/crosswire/xiphos
  Commit: d9ddf93ee2eda611345b6e9929a689c959c32e8a
      https://github.com/crosswire/xiphos/commit/d9ddf93ee2eda611345b6e9929a689c959c32e8a
  Author: Devon Kirk <67167176+hyder365 at users.noreply.github.com>
  Date:   2026-06-19 (Fri, 19 Jun 2026)

  Changed paths:
    M src/main/url.cc

  Log Message:
  -----------
  fix: replace fixed 1023-byte stack buffer with GString in main_url_handler (#1327)

The URL handler for passagestudy.jsp-style URLs used a fixed 1023-byte
stack buffer (tmpbuf) with strncpy to extract the portion of the URL
before '?'. When the URL prefix before '?' exceeded 1022 characters,
strncpy would fill the buffer without null termination, and the
subsequent null-byte write at tmpbuf[place - url] would write past the
boundary. Replace with dynamic GString allocation via g_string_append_len.

Co-authored-by: Devon Kirk <hyder365 at users.noreply.github.com>



To unsubscribe from these emails, change your notification settings at https://github.com/crosswire/xiphos/settings/notifications


More information about the xiphos-source mailing list