[sword-devel] installmgr (and xiphos) crashes (svn 2831)

[Mark Trompell]

Am Sat, 06 Jul 2013 03:51:01 +0200
schrieb "Troy A. Griffitts" <scribe at crosswire.org>:

> Mark and Jaak,

Hi,

> Thanks for your work on this.  I've applied a modified patch from the 
> resolved update from Mark.  Please have a look and let me know if
> this tests ok against your repository.  The modification was to
> simplify the logic using SWBuf instead of a char *.

Tested with my own repository, and crosswire.org (http and https).
Modules install fine, no crash.

> Thanks again for the patch,

Thanks for taking care.

> Troy

Blessings Mark
 
> 
> On 07/04/2013 09:41 AM, Mark Trompell wrote:
> > Replying to myself again, maybe I should find a doctor :)
> > one patch didn't apply right away, I ported it to current trunk and
> > made one big patch file out of the 3.
> > The attached one should work right away.
> > Testet with my own repository and with crosswire.org http(s)
> > repositories. Blessings
> > Mark
> >
> > On Thu, Jul 4, 2013 at 7:40 AM, Mark Trompell
> > <mark at foresightlinux.org> wrote:
> >> ok, just to summarize, what we need is:
> >> https://gitorious.org/~jotik/sword-svn-mirrors/jotiks-sword-trunk/commit/1b8ab91ff994c8584d6c61cb7d334273732d8216?format=patch
> >> https://gitorious.org/~jotik/sword-svn-mirrors/jotiks-sword-trunk/commit/4a261b27a7bec9d9300da6c357666a3851f3d34e?format=patch
> >> https://gitorious.org/~jotik/sword-svn-mirrors/jotiks-sword-trunk/commit/fc85e83a00250a9d172bafc0dca33aa88c6e9e27?format=patch
> >>
> >> Would be great, if someone could add them too trunk before 1.7 is
> >> out.
> >>
> >> On Tue, Jul 2, 2013 at 11:25 AM, Mark Trompell
> >> <mark at foresightlinux.org> wrote:
> >>> On Tue, Jul 2, 2013 at 9:50 AM, Jaak Ristioja <jaak at ristioja.ee>
> >>> wrote:
> >>>
> >>>> Well, if pBufRes == NULL, then pBufRes < pBuf.
> >>>>
> >>>> For reference, here is the latest version of this source file:
> >>>>
> >>>>
> >>>> https://gitorious.org/~jotik/sword-svn-mirrors/jotiks-sword-trunk/blobs/master/src/mgr/curlhttpt.cpp
> >>>>
> >>>> It currently only breaks the loop if !pBufRes.
> >>>>
> >>>> Do you still think there's something wrong with my changes? I
> >>>> have trouble trying to understand what you mean.
> >>> I'm the last to say there is something wrong, I just want to
> >>> understand the reasons.
> >>> So if you break on !pBufRes then the assert() isn't needed
> >>> anymore? Anyway, thanks for taking care, now I hope one of the
> >>> sword devs applies the fix.
> >>>
> >>>> Blessings,
> >>>> Jaak
> >>> Blessing Mark
> >>>
> >>> --
> >>> Mark Trompell
> >>>
> >>> Foresight Linux Xfce Edition
> >>> Cause your desktop should be freaking cool
> >>> (and Xfce)
> >>
> >>
> >> --
> >> Mark Trompell
> >>
> >> Foresight Linux Xfce Edition
> >> Cause your desktop should be freaking cool
> >> (and Xfce)
> >
> >
> >
> >
> > _______________________________________________
> > sword-devel mailing list: sword-devel at crosswire.org
> > http://www.crosswire.org/mailman/listinfo/sword-devel
> > Instructions to unsubscribe/change your settings at above page
>