[sword-devel] sword::ListKey::Count() and sword::ListKey::GetElement() constness
Troy A. Griffitts
scribe at crosswire.org
Fri Jul 5 18:46:23 MST 2013
Hi Jaak,
You're only partially correct. GetElement returns a non-const pointer
to a container member. This method should not be made const. Count
should be const.
Working toward 2.0, we've been normalizing method names and deprecating
the old methods. We have not yet normalized ListKey. When we do, I will
be sure to make getCount() const and provide both a const and non-const
getElement. Thanks for the heads up.
On 07/05/2013 10:26 PM, Jaak Ristioja wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi!
>
> I think sword::ListKey::Count() and sword::ListKey::GetElement()
> should be declared const. We have several places in BibleTime's source
> code where we just const_cast to work around this bug. Should be
> relatively easy to fix afaik.
>
> Blessings,
> Jaak
>
> PS: Will a fix for this be included in the next version of Sword?
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.20 (GNU/Linux)
>
> iQgcBAEBAgAGBQJR1yvhAAoJEEqsYmEt1rCOq8U//1hwvssIVG1wMYWSA7cZ5nkj
> cfxJPfG34CN8YTuBxOEh1M0QzBcvv4jyZE9Vk4/67fWud6Kpe8ByZu6Y1UI/+aVe
> o58QQ4nJNxwYC/x4Svh1E7D4Cb/vdPLqtj5ZNoUZK4EwzEEu3OE25ZcznuQq0Sge
> Eir3zVeqhT7OCLv7zxvQkwY9+xZKacwu/rSropGuo2O6wfR6FnpRs/CYZT0BEos2
> ltoEXxtNZBgtjC09WdtofjFx+ZYg/22/mR55Ic+oYUA2RrQTKr4v21nHHNQVLIWY
> Z/5fH+9eAYHtpieKRht/9jtR1pIB6INQuwOE2FOzqGvKNRzizMsWeNd20gUf0yoK
> VbdQRM7h96plor0Te5MgxM6NSdt+xSiRHrog0T3DJj9Uaf5Q5psR+0JZW7SY9sc4
> MIP6civitHkorx2xFg6Vi+9Pb7YcRPBWQYxhAePRgdOf2u5r6SbWw3ObG5B8WRaX
> k1sLuiPnk06sE1Rm3cwwc5AukaGakFAZZrVuCnEuSAI20ULHCBppIo4I91WsAYFT
> LKolEB147zhuqltI31uyQpjYj2FLK+JQeAFwQ6D0ugPaIzVqBujYDLkfVgXUezXg
> Iur3OPqmWW+kLZVBynh3mjU4hAB+JLommcXCfq1g112YtqMOUEELyqiyFIPT89hK
> 6YUnNORDVCZN3T5J5B88tnbHO/jJfmygTHTZeZNMlpBjU8H22Lb3mv90ifrx/kop
> ZDq4mmTbKVFJ7EHM76jThfk6j2olPfmADhYXdD9h/TO+cb00xKnawVwBmxlMHTek
> vasJl3PU6XJZX2lpMqmCWLYb2w+zGc2VBHXp4AOP8EWDGLmhUWaN37EFtVN6yzbF
> bQwUklJa+HtFTwpfJPLrKc9lR/qe6gVoJy8UyzmZWHg78i9xv2oEv4p3VuWArUKh
> M+ABfup/zcaedHGqU2oQRUnKoL7a5BkNV6E/lTNY2gWTr93yGGa98uNqA6Dm3VR9
> uB4dVK0I4YFp7v6B9B+Lm+gVHaLYPOSXC+o7ANvsAi/IKSyy5cMTiraZIbDXH+ZU
> Hkt+ueQyUJbMTfx95sHnl1yw6GSWczIiYCo3X+gjGxe+D8RMXLEy9dYDI7f2I0Z/
> gbf90zs299CRj03DPLFnBV8q/76UbtyRnac9dP4HP7UjebLDlfMfa6A2/H3Tc+Z7
> dVB5iHFzFkYb1m/vnHXm6R8n1GA+HDYKmMHfBHR2qAFfZ3k6a0768VNd5/sA2Xts
> Oh3uyPqP4B6UgyMiKZ8IFSq//zPCcvb0aSWxM34VsRpjle1omjlyvpagWWYZC3KD
> cSBoM61zInMugKm5NvyE/6HUOP0q/CjQ7aifXamMHB6WjCOZ3zp0Z5BQme19XIKQ
> PaR8q1vKyI1HTLixqXE7NwQsMGUK8c1c67yoNMWL9qrxbChT+GO7jPRlDqJbDE3D
> pVhKeSKVIKHxAzIoFILSYiQ1WPKWOeO3i4DQV7eYsYClgR4OCUp+HEfXUzbh63Z6
> TPABmRWC+vLSMyWUPzKoIg968PQgt1H9ZQ4iGjVkyNesnDI7e2luplimdDBEGxQ9
> dJSqXA4PhpSZ2ywf8XomqACfoNSlBjbem2STP1uBaSs/PRSrp3N0nxkDMneQr+Th
> tRuX4llKumTyH38w8x5cS6/TjvBb2T6DtUMXzXaX+A6N7zul3AgHV4BcSGjqAqai
> +pE7UnxQjf2PqNiYx+BNCHBlicWzNPINHJ4w1EQDyqdmwqfopwjNIM/3hkThq7EP
> ojiyYkcJxzpgdTdkvgZXeMtp55ktA7VAFct3Oz+ktuOMlkpCVO0w9t/mrx6NIbyF
> r3ZWlvYQV71BCtOySkEE1mQIPx92FmoAluJIIo+f9wfw3Qud+p/J0nK7FzV1tbD2
> cSjcQck+oE6/hMia33bM5AwC37JRGwl/0xJDOneU6sLdftv49/v2MLk5GIgOIVlk
> oTjqRCWTLl6cDo6MTs4VwVYKwURoLwIVrVlRgedUmJLZy/mGwvBXKz7PUWZnGz7m
> WmwuaX2BVey1TcHapkzPvDHGtaF+21vZkgelW2V1r11LCfLDfv3arPLcDhmsh0le
> pWCxE1DaHLHA802HgallhJmOzu3SaghRTP4grqkN+D2KhowIfn5eictD6AXf/5x+
> xSr+JseukdSuaN2kJ5l364GSX2QyD6TvK2jewqk1hMAkWfZ6SHf/4nMTaY7OS4T9
> C1HSEbtzFyFiOmmFsdfoDQH4SFOjJGHPJDrW3mnbXbyeZ/2sITkBUEzu2XhqAzLV
> 4WaR/2fN8GeR9G3F9aLlVs2Bggea5yz6Opb7PtQYvofDFeni7y60qQdt3UyTWHPc
> Sqo269dxNVqQ22i7PQd4TnIIWTHNiKzt5kgiMuENq7B8PzqhydhnDap2QsmwqP8I
> GSsGcv+8cVx7g5FwVZ2Q63celrxXG/UOSidJyO5xwnwEmYCgYcUqqmZS4HmgJiB1
> icQVG4c87FCclqBho15Cy7jCLVFf+ZRoBv+SxTJnypu5VyaSZlK5mKsEPAf1ASaA
> vH8W+eaJR/w6dKLOf16oqywrqQbKrJ49qOIqFp93Gz5X+I3hU1xv9hX2et2casDV
> JABBOSVWRJPdMicNGGAVsQ9yy3ByexOPKWTdS0dmIl4uL6xPBOtfZw11dExcztqP
> iWnpO6OBMNZ/49L3N2iXPUJOuuq9pYe635WXLxpL5pbcNLQV1teHxjjtQ1jvNuJ/
> yd4j/iL3zLKsYMbUgBDg
> =68Yv
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> sword-devel mailing list: sword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
More information about the sword-devel
mailing list