[Ils-source] r1393 - trunk/webapp/api/course/get

[scribe at crosswire.org]

Author: scribe
Date: 2016-02-16 16:55:46 -0700 (Tue, 16 Feb 2016)
New Revision: 1393

Modified:
   trunk/webapp/api/course/get/index.jsp
Log:
added error output when course not found


Modified: trunk/webapp/api/course/get/index.jsp
===================================================================
--- trunk/webapp/api/course/get/index.jsp	2016-02-16 23:22:04 UTC (rev 1392)
+++ trunk/webapp/api/course/get/index.jsp	2016-02-16 23:55:46 UTC (rev 1393)
@@ -60,17 +60,26 @@
 	SimpleDateFormat df_out = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss Z");
 	df_out.setTimeZone(TimeZone.getTimeZone("GMT"));
 
+	++errCode;
 	if (courseID > -2 || courseNumber != null) {
 		Vector<Course> courses = null;
 		if (courseID == -1) courses = Course.getAllCourses(ilsSession);
 		else {
 			courses = new Vector<Course>();
-			if (courseID > -1) try { courses.add((Course)Course.getCourse(ilsSession, courseID)); } catch (Exception e) {}
-			else if (courseNumber != null) try { courses.add((Course)Course.getCourseByNum(ilsSession, courseNumber)); } catch (Exception e) {}
+			Course c = null;
+			if (courseID > -1) c = Course.getCourse(ilsSession, courseID);
+			else if (courseNumber != null) c = Course.getCourseByNum(ilsSession, courseNumber);
+			if (c == null) {
+				out.print("<error code=\""+errCode+"\" message=\"Course not found.\"/>");
+				return;
+			}
+			courses.add(c);
 		}
 		out.print("<courses count=\""+courses.size()+"\">\n");
-		for (Object o : courses) {
-			out.print(((Course)o).toXML(detailLevel));
+		if (courses.size() > 0) {
+			for (Course c : courses) {
+				out.print(c.toXML(detailLevel));
+			}
 		}
 		out.print("</courses>\n");
 		return;