[xiphos-source] [crosswire/xiphos] b23577: Fix GTK critical error causing freeze when changin...

[bgermann]

  Branch: refs/heads/master
  Home:   https://github.com/crosswire/xiphos
  Commit: b2357712a4a77f8407634d417c76f457f44117b5
      https://github.com/crosswire/xiphos/commit/b2357712a4a77f8407634d417c76f457f44117b5
  Author: bgermann <bage at debian.org>
  Date:   2026-02-15 (Sun, 15 Feb 2026)

  Changed paths:
    M src/gtk/parallel_tab.c
    M src/gtk/tabbed_browser.c

  Log Message:
  -----------
  Fix GTK critical error causing freeze when changing Bible books (#1272)

Fixed a critical bug where Xiphos would freeze when attempting to change
Bible books, throwing the GTK error:
"gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed"

Root cause: The parallel_vbox widget was being packed into widgets.page
twice - once during creation in _create_parallel_tab() and again by the
caller in tabbed_browser.c during session restore. GTK does not allow a
widget to be added to a container when it already has a parent.

Remove the automatic packing of parallel_vbox into widgets.page from
_create_parallel_tab(). The function now only creates and returns the
widget, following GTK best practices of separating widget creation from
placement.

Uncomment a gtk_box_pack_start() call to ensure the parallel tab widget
is properly packed when opening a parallel view in a new tab.

The widget is now packed exactly once by the caller, preventing the
"widget already has a parent" error and eliminating the freeze.



To unsubscribe from these emails, change your notification settings at https://github.com/crosswire/xiphos/settings/notifications