[xiphos-source] [crosswire/xiphos] 5fb9b9: Fix for #921: Caret in the text (#1382)

[LAfricain]

  Branch: refs/heads/master
  Home:   https://github.com/crosswire/xiphos
  Commit: 5fb9b9836184ff3c852bcefbdfd6c36806a5acc5
      https://github.com/crosswire/xiphos/commit/5fb9b9836184ff3c852bcefbdfd6c36806a5acc5
  Author: L'Africain <fr.cyrille at tiberiade.be>
  Date:   2026-08-20 (Thu, 20 Aug 2026)

  Changed paths:
    M src/main/display.cc
    M src/webkit/wk-html.c
    M src/webkit/wk-html.h
    M src/xiphos_html/xiphos_html.c

  Log Message:
  -----------
  Fix for #921: Caret in the text (#1382)

* Enable WebKit caret browsing in Bible text and commentary panes (fixes #921)

Restricted to TEXT_TYPE and COMMENTARY_TYPE panes: enabling caret
browsing on every WkHtml instance simultaneously (dictionary,
sidebar, etc.) was found to interfere with keyboard caret navigation
(Down/Page_Down) in the active pane, even though the affected pane
kept receiving every key event normally.

* Close chapter anchor immediately instead of wrapping chapter title/intro

Discovered while investigating #921: wrapping the chapter title and
intro material (which legitimately contain block-level <div>/<h2>
elements) inside an inline <a name=...> tag is invalid HTML. WebKit's
HTML5 parser silently fragments/duplicates the <a> element via the
adoption agency algorithm to recover, which can leak inline styles
(e.g. italics) past their intended scope in some chapters.

Does not fully resolve the italics-leak issue on its own (a deeper
cause was also found in cross-chapter OSIS section boundaries and in
getVerseBefore()'s tag-crossing markup); tracked separately.

---------

Co-authored-by: lafricain79 <lafricain79 at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/crosswire/xiphos/settings/notifications