[xiphos-source] [crosswire/xiphos] 14657b: Fix duplicate *b* bookmark-source links on verses ...

[LAfricain]

  Branch: refs/heads/master
  Home:   https://github.com/crosswire/xiphos
  Commit: 14657b51c9ca10e94c428436ee3cfaab4344aaf5
      https://github.com/crosswire/xiphos/commit/14657b51c9ca10e94c428436ee3cfaab4344aaf5
  Author: L'Africain <fr.cyrille at tiberiade.be>
  Date:   2026-08-16 (Sun, 16 Aug 2026)

  Changed paths:
    M src/main/display.cc

  Log Message:
  -----------
  Fix duplicate *b* bookmark-source links on verses after a range's start (#1380)

build_tag_color_map() carried a manual hyphenated-range expansion
(searching the raw bookmark key text for ":<verse>-<digits>") that
predated the fix to BackEnd::parse_verse_list() itself. Now that
parse_verse_list() properly expands a range like "1Tim 2:9-12" into
ne list element per verse, this leftover manual expansion ran a
second time for every verse after the range's start, appending a
second, duplicate bookmark-source entry into the (now append-based,
not first-wins) tag_color_map for those verses -- producing two *b*
links instead of one on verses 10-12 while verse 9 correctly showed
only one.

Remove the now-redundant manual expansion; parse_verse_list() alone
is sufficient.

Co-authored-by: lafricain79 <lafricain79 at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/crosswire/xiphos/settings/notifications