<div dir="ltr"><div>To ease testing purposes it's possible we could add a third fallback on a dummy version number so that a raw source archive with no history or build information could be built. This might be confusing for end users however, I kind of prefer actually _failing_ to build if they are doing it wrong rather than ending up with a successful build with garbage information.</div><div><br></div><div>For local testing purposes it's actually really easy to make a git-archive buildable yourself, you just have to inject the version information. Just `echo 0.0.0 > cmake/source_version.txt` after you extract. For now that's the only blocker.<br></div><div><br></div><div>For CI testing purposes I think actually testing the whole process on the generated source_package as we distribute to users is preferable.</div><div><br></div><div>There are a couple other things we could be doing with the built package source that are impossible with git archives. One we could do signed releases. Two we could get the rest of the vendored code out of the main git tree while still including it in in the built sources. More come to mind, but suffice it to say I think this is the right architecture.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 11, 2020 at 9:55 AM Greg Hellings <<a href="mailto:greg.hellings@gmail.com">greg.hellings@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 11, 2020 at 1:23 AM Caleb Maclennan <<a href="mailto:caleb@alerque.com" target="_blank">caleb@alerque.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Because the Git generated archive of the raw repository contents is not the same contents as the generated source packages. Specifically the former has no information about what version it is. The two ways to get this information are to have git history (i.e. you can use a clone of the repository to build) or to have a source build that has this generated information present (i.e. our generated version specific tarballs that have the relevant information cached inside).<br></div></div></blockquote><div><br></div><div>I do want to say: it's a bit of a nuisance to do testing this way, though. In order to generate a source tar, I have to successfully run CMake against the tree, which means I need all the devel dependencies installed on my machine. It's not impossible, but it is a bit of a pain. I'm all in favor of the CPack generators for Windows installers, but it's not terribly convenient for the source tar generation.</div><div><br></div><div>--Greg<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 10, 2020 at 5:41 PM Karl Kleinpaste <<a href="mailto:karl@kleinpaste.org" target="_blank">karl@kleinpaste.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<font face="FreeSerif">github release process automatically produces
tarfiles, zip and tar.gz.<br>
Yet our release machinery also produces tarfiles, tar.gz and
tar.xz.<br>
Why?<br>
</font>
</div>
_______________________________________________<br>
xiphos-devel mailing list<br>
<a href="mailto:xiphos-devel@crosswire.org" target="_blank">xiphos-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/xiphos-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/xiphos-devel</a><br>
</blockquote></div>
_______________________________________________<br>
xiphos-devel mailing list<br>
<a href="mailto:xiphos-devel@crosswire.org" target="_blank">xiphos-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/xiphos-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/xiphos-devel</a><br>
</blockquote></div></div>
_______________________________________________<br>
xiphos-devel mailing list<br>
<a href="mailto:xiphos-devel@crosswire.org" target="_blank">xiphos-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/xiphos-devel" rel="noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/xiphos-devel</a><br>
</blockquote></div>