<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Apr 26, 2020, 02:55 Caleb Maclennan <<a href="mailto:caleb@alerque.com">caleb@alerque.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sun, Apr 26, 2020 at 10:39 AM Greg Hellings <<a href="mailto:greg.hellings@gmail.com" target="_blank" rel="noreferrer">greg.hellings@gmail.com</a>> wrote:<br>
> We aren't quite there, yet.<br>
<br>
Sure we are. But I think we might be talking about different things.<br>
My comments were all about local tagging and builds. That part should<br>
be 100% working now, or my job on that PR isn't done. You should be<br>
able to tag locally, then build and get the right release version.<br>
This can be tested just by `git tag`, then build and run it and see<br>
what version it says it is. `make -C build source_package` should also<br>
have the right filename. (Be sure to delete any such test tags before<br>
pushing!)<br>
<br>
What you are talking about is automating the builds on Github when a<br>
tag is pushed to the remote repository so there is no local build step<br>
needed. Great work on that and sorry I havn't been more help by the<br>
way. That's the part you mean is not quite there yet, correct?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Correct. Currently he can tag and do build, then upload. I'm very close to getting the release process down to tag, push tag, relax with family while GA does builds and uploads.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
> I have CI passing all builds and creating the Windows artifacts, but I don't yet have it creating the final build artifacts for publishing *quite* yet.<br>
<br>
I haven't looked at your code yet, but I assume you are building and<br>
posting artifacts on all [push, pull_request] jobs, but filtering `on:<br>
push: tags: [ "v*" ]` and running an extra job on them to post the<br>
correct artifacts to a Github release matching the tag ... correct? Or<br>
at least that's the goal, no?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">That is the goal. Currently I have Windows artifacts building and stashing on every commit or tag. I also have Linux builds completing.</div><div dir="auto"><br></div><div dir="auto">All that remains is adding the Linux artifact stashing and releasing on tag events. That's just a matter of about four more steps in Github, but I got distracted by sleep, which I'm about to do again. 😂 </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
> I would agree with this sentiment. Fedora is a bit loosey-goosey with what it allows in, but you're not going to slip this past other distros as a patch release. It really isn't, especially once we tossed in the change from libgsf to minizip. Let's just cut loose the next version as 4.2.0 and maybe take the extra few weeks to figure out editor/HTML needs. At least a roadmap even if we don't finish them in time to make 4.2.0, we can have 4.3.0 well on its way.<br>
<br>
I definitely don't want to hold up the release any longer than it<br>
needs to be and I'm not advocating for stuffing new features in to<br>
make it worthy of a minor version number bump, all I'm saying is that<br>
it already needs at least a minor version bump with what's in the<br>
release so far. The editor can go in 4.3. I wouldn't put anything else<br>
on the roadmap for 4.2 other than getting the build and release<br>
process ironed out.<br>
<br>
_______________________________________________<br>
xiphos-devel mailing list<br>
<a href="mailto:xiphos-devel@crosswire.org" target="_blank" rel="noreferrer">xiphos-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/xiphos-devel" rel="noreferrer noreferrer" target="_blank">http://www.crosswire.org/mailman/listinfo/xiphos-devel</a><br>
</blockquote></div></div></div>