<div dir="auto">Thanks. I am not privy to the patches email inbox, so this mailing list is the way to reach me for CMake things. I'll review these when I have the opportunity.<div dir="auto"><br></div><div dir="auto">--Greg</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Nov 26, 2022, 13:46 Peter von Kaehne <<a href="mailto:refdoc@gmx.net">refdoc@gmx.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><br><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div>How to suggest improvements to the sword project?</div></div></div></blockquote><div><br></div><div><br></div>You did it the right way. It just is a bit on/off as a project. GHellings is the cmake pumpkin holder as far as I know. I bcc him on a different email address. <div><br></div><div>Peter<br><div><br></div><div><br></div><div><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div><br></div><div>BR,</div><div><br></div><div>Zdenko<br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>From: <b class="gmail_sendername" dir="auto">ZdPo Ster</b> <span dir="auto"><<a href="mailto:zdposter@gmail.com" target="_blank" rel="noreferrer">zdposter@gmail.com</a>></span><br>Date: Sun, 6 Nov 2022 at 22:22<br>Subject: cmake patches<br>To: <<a href="mailto:patches@crosswire.org" target="_blank" rel="noreferrer">patches@crosswire.org</a>><br></div><br><br><div dir="ltr"><div>Hello,</div><div><br></div><div>please find 3 few patches related to cmake build (tested on windows with MSVC 2019):</div><div><ol><li>cmake_fix_deprecation.patch - cmake version 3.23.2 produce depreciation warning for old minimum version, co IMO it is time to increase expected cmake version</li><li>cmake_fix_msvc.patch - there is no "/O3" options in current MSVC[1]</li><li>cmake_git_svn.patch - I use git svn for accessing code, but cmake produce error because of missing svn executable. He is patch that fixed it + code for detecting svn revision (MYSVN_WC_REVISION) from git</li></ol><div></div><div>[1] <a href="https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=msvc-160" target="_blank" rel="noreferrer">https://learn.microsoft.com/en-us/cpp/build/reference/o-options-optimize-code?view=msvc-160</a></div><div><br></div><div>Zdenko<br></div></div></div>
</div></div></div>
</div></blockquote></div></div></div><div dir="auto" role="textbox" aria-label="Message Body"><div><div><blockquote type="cite"><div dir="ltr"></div></blockquote></div></div></div><div dir="auto" role="textbox" aria-label="Message Body"><div><div><blockquote type="cite"><div dir="ltr"></div></blockquote></div></div></div><div dir="auto"><div><div><blockquote type="cite"><div dir="ltr"><span>_______________________________________________</span><br><span>sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank" rel="noreferrer">sword-devel@crosswire.org</a></span><br><span><a href="http://crosswire.org/mailman/listinfo/sword-devel" target="_blank" rel="noreferrer">http://crosswire.org/mailman/listinfo/sword-devel</a></span><br><span>Instructions to unsubscribe/change your settings at above page</span><br></div></blockquote></div></div></div></blockquote></div>