<div dir="ltr"><div>installmgr on windows (git svn revision 3887) does not seem to have this problem:</div><div><br></div><div><span style="font-family:monospace">>dir %SWORD_PATH%\modules\lexdict\zld\slkstrongsgreek<br> Volume in drive F is Elements<br> Volume Serial Number is A056-4331<br><br> Directory of F:\win64\share\sword\modules\lexdict\zld\slkstrongsgreek<br><br>13.11.2022 14:49 <DIR> .<br>13.11.2022 14:49 <DIR> ..<br>13.11.2022 14:49 95 608 dict.dat<br>13.11.2022 14:49 44 992 dict.idx<br>13.11.2022 14:49 778 434 dict.zdt<br>13.11.2022 14:49 1 504 dict.zdx</span></div><div><span style="font-family:monospace"><br></span></div><div><span style="font-family:monospace">>installmgr -li SlkStrongsGreek SlkStrongsGreek<br><br>Installed module: [SlkStrongsGreek]</span></div><div><span style="font-family:monospace"><br></span></div><div><span style="font-family:monospace">>dir %SWORD_PATH%\modules\lexdict\zld\slkstrongsgreek<br> Volume in drive F is Elements<br> Volume Serial Number is A056-4331<br><br> Directory of F:\win64\share\sword\modules\lexdict\zld\slkstrongsgreek<br><br>13.11.2022 14:49 <DIR> .<br>13.11.2022 14:49 <DIR> ..<br>13.11.2022 19:38 95 608 dict.dat<br>13.11.2022 19:38 44 992 dict.idx<br>13.11.2022 19:38 778 553 dict.zdt<br>13.11.2022 19:38 1 504 dict.zdx</span></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, 13 Nov 2022 at 09:55, Tobias Klein <<a href="mailto:contact@tklein.info">contact@tklein.info</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I could just reproduce this issue.<br>
<br>
I have a test user with an older set of SWORD modules and by keeping a <br>
backup of the .sword directory I could switch back to the state before <br>
the module update.<br>
<br>
Once I applied the module update again ... I had the same issue as <br>
described below.<br>
<br>
The way how I have implemented the module update is by simply running <br>
installModule on top of an existing installation. Is that an invalid <br>
approach?<br>
<br>
What I will now do next is add an explicit InstallMgr::removeModule() <br>
call before re-installing the new version.<br>
<br>
If that's what's needed - maybe there should be an upgradeModule() <br>
method? Or alternatively the installModule() should return with an error <br>
code when the given module is already installed?<br>
<br>
This may also explain how I ran into this before ... I have an e2e <br>
integration test suite of Ezra Bible App. And that test suite <br>
automatically runs through the module installation process as one of the <br>
test scenarios. It doesn't cleanup the .sword directory initially, <br>
though. Which means that it installs modules on top of existing modules <br>
... and that's where I may have seen this issue before as well!<br>
<br>
Best regards,<br>
Tobias<br>
<br>
On 11/12/22 10:56 AM, Tobias Klein wrote:<br>
> Hi all,<br>
><br>
> I have observed a bug with regard to SWORD module installation.<br>
><br>
> I just tried to update existing modules by "installing them again" <br>
> using InstallMgr::installModule().<br>
><br>
> I ended up with a situation where the installation apparently finished <br>
> ok based on return codes, but then I found the following:<br>
><br>
> The *.conf files in the mods.d directory are still present, but the <br>
> module contents under modules/texts/ztext are actually removed for the <br>
> modules that I tried to update.<br>
><br>
> Has anyone seen this behavior before? Is there an explanation?<br>
><br>
> The modules are then still listed as installed, but there is no <br>
> content ...<br>
><br>
> I have seen this before at various times with individual modules, but <br>
> did not report it. Now that I have this bug at a larger scale (for a <br>
> bigger list of modules I tried to update) I felt like it's worth <br>
> reporting.<br>
><br>
> Best regards,<br>
> Tobias<br>
><br>
> PS: I have been using SWORD SVN Rev. 3873 (from Nov. 2021).<br>
><br>
> _______________________________________________<br>
> sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank">sword-devel@crosswire.org</a><br>
> <a href="http://crosswire.org/mailman/listinfo/sword-devel" rel="noreferrer" target="_blank">http://crosswire.org/mailman/listinfo/sword-devel</a><br>
> Instructions to unsubscribe/change your settings at above page<br>
_______________________________________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank">sword-devel@crosswire.org</a><br>
<a href="http://crosswire.org/mailman/listinfo/sword-devel" rel="noreferrer" target="_blank">http://crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br>
</blockquote></div>