<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Greg,</p>
<p>Would you mind having a look regarding the CMake configuration
for how zlib is handled on Windows?<br>
This issue described below is not resolved yet. I tried to make
some changes in the CMake configuration some time ago, but did not
succeed.<br>
<br>
Best regards,<br>
Tobias<br>
</p>
<div class="moz-forward-container">-------- Forwarded Message
--------
<table class="moz-email-headers-table" cellspacing="0"
cellpadding="0" border="0">
<tbody>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Subject:
</th>
<td>Re: [sword-devel] Latest SWORD trunk / Build issue on
Windows (Root-cause: CMake configuration related to zlib)</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">Date: </th>
<td>Sun, 14 Mar 2021 01:13:43 -0600</td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">From: </th>
<td>Greg Hellings <a class="moz-txt-link-rfc2396E" href="mailto:greg.hellings@gmail.com"><greg.hellings@gmail.com></a></td>
</tr>
<tr>
<th valign="BASELINE" nowrap="nowrap" align="RIGHT">To: </th>
<td>Tobias Klein <a class="moz-txt-link-rfc2396E" href="mailto:contact@tklein.info"><contact@tklein.info></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<div dir="ltr">
<div>So is our solution just to remove the conditional files for
when ZLib is not found? Is ZLib now a hard dependency instead
of an optional one?</div>
<div><br>
</div>
<div>--Greg<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Mar 13, 2021 at 10:01
AM Tobias Klein <<a href="mailto:contact@tklein.info"
moz-do-not-send="true">contact@tklein.info</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hi Greg,</p>
<p>Not sure whether you saw this ... I need your help on
this.<br>
<br>
Have a great weekend!<br>
</p>
<p>Best regards,<br>
Tobias<br>
</p>
<div>On 2/22/21 8:30 AM, Tobias Klein wrote:<br>
</div>
<blockquote type="cite">
<p>Hi Greg,</p>
<p>Would you mind taking a look?<br>
I checked what needs to be done to remove the zlib
references, but it was difficult to determine all the
places that need to be changed. Let me know if I can
help.<br>
</p>
<p>Best regards,<br>
Tobias<br>
</p>
<div>On 2/16/21 11:16 PM, Tobias Klein wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">
<div dir="auto">Dear Troy,</div>
<div dir="auto"><br>
</div>
<div dir="auto">Is it maybe this reference in
/cmake/sources.cmake (line 214)</div>
<div dir="auto"><br>
</div>
SET(sword_zlib_nofound_SOURCES
<div dir="auto"> src/utilfuns/zlib/adler32.c</div>
<div dir="auto"><br>
</div>
<div dir="auto">Best regards,</div>
<div dir="auto">Tobias</div>
<div dir="auto">
<div dir="auto">
<div dir="auto"><br>
</div>
<div id="gmail-m_254990109900649299aqm-original"
style="color:black">
<div>
<div style="color:black">
<p
style="color:black;font-size:10pt;font-family:sans-serif;margin:8pt
0px">Am 16. Februar 2021 22:42:51 schrieb
"Troy A. Griffitts" <a
href="mailto:scribe@crosswire.org"
target="_blank" moz-do-not-send="true"><scribe@crosswire.org></a>:</p>
<blockquote type="cite" class="gmail_quote"
style="margin:0px 0px 0px
0.75ex;border-left:1px solid
rgb(128,128,128);padding-left:0.75ex">
<p>Dear Tobias,</p>
<p>I have just had a look at a pristine
checkout of SWORD trunk and I have no
trace of adler32.c in any
CMakeList.txt. Could this be similar to
the stray symbols and such you were
having with your build framework
previously, which we stipulated was due
to no completely cleaning build staging
folders?</p>
<p>If you can find the CMakeList.txt with
a line 85 containing a reference to
adler32.c, please let me know and I will
continue to investigate.</p>
<p>Glad the new toUpper code is working
for you.</p>
<p>Troy</p>
<p><br>
</p>
<div>On 2/16/21 4:18 AM, Tobias Klein
wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">
<div dir="auto">Hi Zdenko,</div>
<div dir="auto"><br>
</div>
<div dir="auto">That Windows build
(automated via GitHub Actions, also
considering zlib) has been
previously working (Last time when
1.9.0 was released), so I would
rather guess that this is a
regression in the CMake
configuration of SWORD.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Best regards,</div>
<div dir="auto">Tobias</div>
<div dir="auto"><br>
</div>
<div style="color:black">
<div>
<div style="color:black">
<p
style="color:black;font-size:10pt;font-family:sans-serif;margin:8pt
0px">Am 16. Februar 2021
09:21:01 schrieb ZdPo Ster <a
href="mailto:zdposter@gmail.com" target="_blank" moz-do-not-send="true"><zdposter@gmail.com></a>:</p>
<blockquote type="cite"
class="gmail_quote"
style="margin:0px 0px 0px
0.75ex;border-left:1px solid
rgb(128,128,128);padding-left:0.75ex">
<div dir="ltr">
<div>I expect that zlib is
installed on Mac by
default, while on windows
cmake configuration does
not find a suitable zlib
installation, so it tries
to build it (but source
code is missing).</div>
<div><br>
</div>
<div>Try to install <a
href="https://github.com/madler/zlib"
target="_blank"
moz-do-not-send="true">https://github.com/madler/zlib</a>
with cmake before
configuring and building
the sword.</div>
<div><br>
</div>
<div>Zdenko<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr"
class="gmail_attr">On Mon,
15 Feb 2021 at 18:33,
Tobias Klein <<a
href="mailto:contact@tklein.info"
target="_blank"
moz-do-not-send="true">contact@tklein.info</a>>
wrote:<br>
</div>
<blockquote
class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px
solid
rgb(204,204,204);padding-left:1ex">
<div>Hi,
<div><br>
</div>
<div>I have observed a
build issue with the
latest SWORD trunk on
Windows.</div>
<div><br>
</div>
<div>I am getting this
message:</div>
<div><br>
</div>
<div>
<div>
<div
style="box-sizing:border-box;display:flex;line-height:20px"><span style="box-sizing:border-box;margin-left:16px;display:inline-block;overflow-x:auto;white-space:pre-wrap"><span style="box-sizing:border-box">CMake Error at CMakeLists.txt:85 (ADD_LIBRARY):
</span></span></div>
</div>
<div>
<div
style="box-sizing:border-box;line-height:20px;display:flex"><a
href="https://github.com/ezra-project/sword-build-win32/runs/1904990888?check_suite_focus=true#step:12:112"
style="box-sizing:border-box;text-decoration:none;width:48px;overflow:hidden;text-align:right;text-overflow:ellipsis;white-space:nowrap;display:inline-block"
target="_blank"
moz-do-not-send="true">112</a><span style="box-sizing:border-box;margin-left:16px;display:inline-block;overflow-x:auto;white-space:pre-wrap"><span style="box-sizing:border-box"> Cannot find source file:
</span></span></div>
</div>
<div>
<div
style="box-sizing:border-box;display:flex;line-height:20px"><a
href="https://github.com/ezra-project/sword-build-win32/runs/1904990888?check_suite_focus=true#step:12:113"
style="box-sizing:border-box;text-decoration:none;width:48px;overflow:hidden;text-align:right;text-overflow:ellipsis;white-space:nowrap;display:inline-block"
target="_blank"
moz-do-not-send="true">113</a><span style="box-sizing:border-box;margin-left:16px;display:inline-block;overflow-x:auto;white-space:pre-wrap"><span style="box-sizing:border-box">
</span></span></div>
</div>
<div>
<div
style="box-sizing:border-box;display:flex;line-height:20px"><a
href="https://github.com/ezra-project/sword-build-win32/runs/1904990888?check_suite_focus=true#step:12:114"
style="box-sizing:border-box;text-decoration:none;width:48px;overflow:hidden;text-align:right;text-overflow:ellipsis;white-space:nowrap;display:inline-block"
target="_blank"
moz-do-not-send="true">114</a><span style="box-sizing:border-box;margin-left:16px;display:inline-block;overflow-x:auto;white-space:pre-wrap"><span style="box-sizing:border-box"> src/utilfuns/zlib/adler32.c</span></span></div>
</div>
</div>
<div><br>
</div>
<div>When checking the
content of
/src/utilfuns it
appears like that
folder (zlib) and file
(adler32.c) is
actually missing.</div>
<div><br>
</div>
<div>I am not getting
that error on macOS,
so it seems like it is
a Windows-specific
CMake configuration
issue?</div>
<div><br>
</div>
<div>Best regards,</div>
<div>Tobias</div>
</div>
_______________________________________________<br>
sword-devel mailing list:
<a
href="mailto:sword-devel@crosswire.org"
target="_blank"
moz-do-not-send="true">sword-devel@crosswire.org</a><br>
<a
href="http://crosswire.org/mailman/listinfo/sword-devel"
rel="noreferrer"
target="_blank"
moz-do-not-send="true">http://crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to
unsubscribe/change your
settings at above page</blockquote>
</div>
<div>_______________________________________________</div>
<div>sword-devel mailing list:
<a
href="mailto:sword-devel%40crosswire.org"
target="_blank"
moz-do-not-send="true">sword-devel@crosswire.org</a></div>
<div><a
href="http://crosswire.org/mailman/listinfo/sword-devel"
target="_blank"
moz-do-not-send="true">http://crosswire.org/mailman/listinfo/sword-devel</a></div>
<div>Instructions to
unsubscribe/change your
settings at above page</div>
</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank" moz-do-not-send="true">sword-devel@crosswire.org</a>
<a href="http://crosswire.org/mailman/listinfo/sword-devel" target="_blank" moz-do-not-send="true">http://crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
<div>_______________________________________________</div>
<div>sword-devel mailing list: <a
href="mailto:sword-devel%40crosswire.org"
target="_blank" moz-do-not-send="true">sword-devel@crosswire.org</a></div>
<div><a
href="http://crosswire.org/mailman/listinfo/sword-devel"
target="_blank" moz-do-not-send="true">http://crosswire.org/mailman/listinfo/sword-devel</a></div>
<div>Instructions to unsubscribe/change
your settings at above page</div>
</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
</div>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank" moz-do-not-send="true">sword-devel@crosswire.org</a>
<a href="http://crosswire.org/mailman/listinfo/sword-devel" target="_blank" moz-do-not-send="true">http://crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank" moz-do-not-send="true">sword-devel@crosswire.org</a>
<a href="http://crosswire.org/mailman/listinfo/sword-devel" target="_blank" moz-do-not-send="true">http://crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
</div>
</blockquote>
</div>
</div>
</body>
</html>