<html><head></head><body>Hi Jaak,<br><br>Thanks for reminding us there is a problem here. I am not sure I have my head around this one. What I added was supposed to be a cmake module which worked correctly within svn and outside, as long as a parameter was passed which basically says skip errors.<br><br>If I remember correctly, it was working for you at one point, and then we did some additional enhancements to the cmake build system and then it stopped working for you. Is that correct?<br><br>While I am sure checking for the .svn folder will work, as you suggest, I'd prefer to find out what we did to break the built-in support for skipping problems when not within an svn working directory.<br><br>Greg, any input on this one?<br><br>Troy<br><br><div class="gmail_quote">On February 16, 2021 7:07:47 AM MST, Jaak Ristioja <jaak@ristioja.ee> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hello,<br><br>If changes/fixes to the CMake build system is in queue, please consider <br>taking a look at this BibleTime issue as well. Thanks!<br><br>Best regards,<br>J<br><br>On 08.01.21 01:49, Jaak Ristioja wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hello!<br><br>The capricious CI for BibleTime again fails to build the latest SVN <br>trunk version of Sword with CMake:<br><br>-- Found Subversion: /usr/bin/svn (found version "1.9.7")<br><br>CMake Error at <br>/usr/local/cmake-3.12.4/share/cmake-3.12/Modules/FindSubversion.cmake:99 <br>(message):<br><br> Command "/usr/bin/svn info /tmp/tmp.Tii77pWpje/source" failed with <br>output:<br><br> svn: E155007: '/tmp/tmp.Tii77pWpje/source' is not a working copy<br><br><br>I took a look at the recent Subversion related changes in CMakeLists.txt <br>and propose to add detection that "${CMAKE_CURRENT_SOURCE_DIR}/.svn" <br>exists and that the the Subversion client executable is available on the <br>system, e.g.:<br><br> if(IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/.svn")<br> find_package(Subversion)<br> if(COMMAND Subversion_WC_INFO)<br> Subversion_WC_INFO("${CMAKE_CURRENT_SOURCE_DIR}" MYSVN<br> IGNORE_SVN_FAILURE)<br> endif()<br> endif()<br><br>Note also that I double quoted "${CMAKE_CURRENT_SOURCE_DIR}" in the <br>above so that directories with spaces wouldn't cause an incorrect number <br>of arguments getting passed to Subversion_WC_INFO(). Using if(COMMAND <br>Subversion_WC_INFO) instead of if(Subversion_FOUND) is safer as it <br>allows users to provide their own Subversion_WC_INFO() command in cases <br>where FindSubversion() doesn't work for them (e.g. when subversion is <br>not installed, not found by FindSubversion.cmake or FindSubversion fails <br>to define Subversion_WC_INFO()).<br><br><br>Best regards,<br>J<hr>sword-devel mailing list: sword-devel@crosswire.org<br><a href="http://crosswire.org/mailman/listinfo/sword-devel">http://crosswire.org/mailman/listinfo/sword-devel</a><br>Instructions to unsubscribe/change your settings at above page<br></blockquote><hr>sword-devel mailing list: sword-devel@crosswire.org<br><a href="http://crosswire.org/mailman/listinfo/sword-devel">http://crosswire.org/mailman/listinfo/sword-devel</a><br>Instructions to unsubscribe/change your settings at above page</pre></blockquote></div><br>-- <br>Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>