<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 28, 2020 at 1:02 AM Gary Holmlund <<a href="mailto:gary.holmlund@gmail.com">gary.holmlund@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  
    
  
  <div>
    <p><br>
    </p>
    <div>On 7/27/20 12:44 PM, Greg Hellings
      wrote:<br>
    </div>
    <blockquote type="cite">
      
      <div dir="ltr">
        <div dir="ltr"><br>
        </div>
        <br>
        <div class="gmail_quote">
          <div dir="ltr" class="gmail_attr">On Mon, Jul 27, 2020 at 3:22
            PM Tobias Klein <<a href="mailto:contact@tklein.info" target="_blank">contact@tklein.info</a>> wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div lang="DE">
              <div>
                <p class="MsoNormal"><span lang="EN-US">Maybe it helps:
                    This is how I build bzip2 on Windows with the Visual
                    Studio compiler based on their Git repo </span><u><span style="font-size:9pt;font-family:Consolas;color:rgb(3,47,98);background:white none repeat scroll 0% 0%">git://<a href="http://sourceware.org/git/bzip2.git" target="_blank">sourceware.org/git/bzip2.git</a></span></u><span lang="EN-US">.</span></p>
                <p class="MsoNormal"><span lang="EN-US"> </span></p>
                <p class="MsoNormal"><a href="https://github.com/tobias-klein/sword-build-win32/blob/master/build_bzip2.bat" target="_blank">https://github.com/tobias-klein/sword-build-win32/blob/master/build_bzip2.bat</a></p>
                <p class="MsoNormal"> </p>
                <p class="MsoNormal">Best regards,<br>
                  Tobias</p>
                <p class="MsoNormal"> </p>
                <div style="border-color:rgb(225,225,225) currentcolor currentcolor;border-style:solid none none;border-width:1pt medium medium;padding:3pt 0cm 0cm">
                  <p class="MsoNormal" style="border:medium none;padding:0cm"><b>From: </b><a href="mailto:gary.holmlund@gmail.com" target="_blank">Gary
                      Holmlund</a><br>
                    <b>Sent: </b>Montag, 27. Juli 2020 21:01<br>
                    <b>To: </b><a href="mailto:sword-devel@crosswire.org" target="_blank">SWORD
                      Developers' Collaboration Forum</a>; <a href="mailto:greg.hellings@gmail.com" target="_blank">Greg
                      Hellings</a><br>
                    <b>Subject: </b>Re: [sword-devel] Win32 FileMgr
                    Subclass - BibleTime</p>
                </div>
                <p class="MsoNormal"> </p>
                <p class="MsoNormal"> </p>
                <p class="MsoNormal">On 7/27/2020 7:24 AM, Greg Hellings
                  wrote:</p>
                <p class="MsoNormal">> </p>
                <p class="MsoNormal">> If any other Xiphos developers
                  want to do testing, or if BibleTime </p>
                <p class="MsoNormal">> does any cross compiling from
                  Fedora. You can also find Xiphos </p>
                <p class="MsoNormal">> installers building the latest
                  Xiphos head against this latest Sword </p>
                <p class="MsoNormal">> head. I'm very far from any
                  Windows machine I can use as a test, so if </p>
                <p class="MsoNormal">> anyone else has a Windows
                  machine to test this on - preferably one </p>
                <p class="MsoNormal">> with a username that includes
                  non-ASCII characters in it - then feel </p>
                <p class="MsoNormal">> free to grab that. If the
                  BibleTime Windows builder (Gary?) wants to </p>
                <p class="MsoNormal">> generate builds against the
                  latest SVN HEAD and test in the same </p>
                <p class="MsoNormal">> manner, it would be a huge
                  help.</p>
                <p class="MsoNormal"> </p>
                <p class="MsoNormal">Greg,</p>
                <p class="MsoNormal"> </p>
                <p class="MsoNormal">I tried to build BibleTime with the
                  latest sword svn, but I ran into a </p>
                <p class="MsoNormal">build issue. We don't build with
                  bzip2 because it is not well supported </p>
                <p class="MsoNormal">on Windows. I used the cmake var
                  SWORD_NO_BZIP2=Yes, but the sword build </p>
                <p class="MsoNormal">still required bzip2. Can you fix
                  this?</p>
              </div>
            </div>
          </blockquote>
          <div><br>
          </div>
          <div>Interesting. I was sitting here trying to figure out what
            you could be possibly running into. I don't do my builds
            with bzip2 installed from MinGW!</div>
          <div><br>
          </div>
          <div>Turns out CMakeLists.txt has:</div>
          <div><br>
          </div>
          <div>IF(MSVC)<br>
                 FIND_PACKAGE(BZIP2 REQUIRED)<br>
                 FIND_PACKAGE(XZ REQUIRED)<br>
                 FIND_PACKAGE(ICU REQUIRED)<br>
                 FIND_PACKAGE(CURL REQUIRED)<br>
            ELSE(MSVC)<br>
                 FIND_PACKAGE(BZIP2 QUIET)<br>
                 FIND_PACKAGE(XZ QUIET)<br>
                 FIND_PACKAGE(ICU<br>
                                COMPONENTS data i18n io uc)<br>
                 FIND_PACKAGE(CURL QUIET)<br>
            ENDIF(MSVC)</div>
          <div><br>
          </div>
          <div>No issues taking that out, but why would I have make
            BZip2, XZ, and cURL required on MSVC but not for any builds
            with gcc, even on Windows?</div>
          <div><br>
          </div>
          <div>As for its support, I imagine you can use vcpkg to
            install it? Then you don't have to mess with maintaining
            your own builds.<br>
          </div>
          <div><br>
          </div>
          <div>--Greg<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div lang="DE">
              <div>
                <p class="MsoNormal"> </p>
                <p class="MsoNormal">Gary Holmlund</p>
                <br>
              </div>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
    <p>Greg,</p>
    <p>I just did a local patch to CMakeLists.txt so I could build
      BibleTime. I built BT 3.0.0-rc1 and tested it with non-ascii home
      directory. I used Visual Studio 2019 and Qt 5.15.0. <br>
    </p>
    <p>I was able to install, read, search, etc. I did not see any
      problems.</p>
    <p>Gary<br></p></div></blockquote><div><br></div><div>Perfect - I've committed a fix so that it's not forcing you to find any of those libraries on MSVC.</div><div><br></div><div>If you aren't, you might look into the vcpkg tool, though, as I imagine most of these libraries are able to be found in there. Could reduce your need to maintain any of the dependencies and make it easier to build with the optional libs.</div><div><br></div><div>--Greg<br></div></div></div>