<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Troy,</p>
<p>Thank you very much for your help and for the quick fix !! I can
confirm that now diatheke returns a commentary for Gen.1.1 and
also for Gen.1.2, Gen.1.3, etc. when I use ranges for annotateRef.</p>
<p>Again thank you all for your help for this bug!</p>
<p>I will send again my module to Crosswire team for update. I guess
other modules may be concerned and need to be reimported.<br>
</p>
<p>Best regards,<br>
</p>
<p>--yvand<br>
</p>
<div class="moz-cite-prefix">Le 26/07/2020 à 19:32, Troy A.
Griffitts a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:912a0081-74ce-39e1-c71d-eba076accdc2@crosswire.org">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>Dear yvand,</p>
<p>I believe I've fixed this in osis2mod. osis2mod had code to
deal with linking for ranges, but it checked for the necessity
of a link with ListKey::getCount(), but this only tells how many
elements are in the ListKey, not if any of those elements are
ranges. Oddly, it did have code after this check which would
work find to see if more than 1 verse was referenced-- so
close. Anyway, I think it's now fixed. I added unit tests to
check both osisID verse lists and also annotateRef ranges and
both tests pass.</p>
<p>Thanks for your patience on this one. Please let me know what
you find,</p>
<p>Troy</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 7/25/20 9:30 PM, yvand wrote:<br>
</div>
<blockquote type="cite"
cite="mid:bd0e0298-256a-f912-efb6-61e4f4c7dd90@gmail.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<p>I tried using annotateRef="Gen.1.1 Gen.1.2 Gen.1.3 Gen.1.4"
instead of annotateRef="Gen.1.1-Gen.1.4", the behavior is
different. diatheke gives a commentary for each verse, but I
am not sure it is link entries...<br>
</p>
<p>So now, I don't know what I can do to "fix" this bug
(feature?).</p>
<p>I am lost. I still do not know where is exactly the bug, or
if this is just a frontend feature…<br>
</p>
<p>--yvand<br>
</p>
<div class="moz-cite-prefix">Le 24/07/2020 à 10:44, Troy A.
Griffitts a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:9fa858c1-ed5c-1d0d-de74-e2b5529a490d@crosswire.org">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<p>Yes, linking is not working with annotateRef. Thanks for
the text. If you wouldn't mind rebuilding the module and
changing one entry to an osisID verse list and then testing
again, it would really help finalize what exactly the
problem is. If osisID verse lists do link correctly, then
we simply need to apply the same logic to annotateRef.<br>
</p>
<div class="moz-cite-prefix">On 7/24/20 10:42 AM, yvand wrote:<br>
</div>
<blockquote type="cite"
cite="mid:d634642e-dbc7-5e27-0491-8653c3c03e28@gmail.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<p>I tried it again, here is what I got: <br>
<br>
</p>
<blockquote type="cite" style="color: #000000;">$ diatheke
-b FreCJE -k Gen.1.2 <br>
Genesis 1:2: <br>
(FreCJE) <br>
<br>
$ diatheke -b FreCJE -k Gen.1.3 <br>
Genesis 1:3: <br>
(FreCJE) <br>
</blockquote>
<p><br>
</p>
<p>So nothing :-/</p>
<p>--yvand</p>
<p><br>
</p>
<div class="moz-cite-prefix">Le 24/07/2020 à 10:38, Troy A.
Griffitts a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:5a7c3ed0-e3b6-9f46-c603-11ebf2e667aa@crosswire.org">Hi
yvand, <br>
<br>
Well, that's not an authoritative test. You need to ask
ONLY for verse Gen.1.2. <br>
<br>
SWORD has logic to "skip" contiguous linked verses, so
diatheke might be taking advantage of that to prevent it
from printing out the same commentary 19 times in a row.
The output you see is the desired output when a user
requests the entire chapter. One instance of each
commentary entry. <br>
<br>
To test linking, you need to ask for a verse within the
range, but not the first verse. <br>
<br>
Hope this explains a bit, <br>
<br>
Troy <br>
<br>
<br>
On 7/24/20 10:27 AM, yvand wrote: <br>
<blockquote type="cite">Hey, <br>
<br>
Thanks Troy for your help. I use annotateRef and not
osisID, as mentioned in <a
class="moz-txt-link-freetext"
href="https://wiki.crosswire.org/OSIS_Commentaries"
moz-do-not-send="true">https://wiki.crosswire.org/OSIS_Commentaries</a>
. I tried diatheke, here is what I got : <br>
<br>
<blockquote type="cite">diatheke -b FreCJE -k Gen.1 |
head <br>
Genesis 1:1: <div annotateRef="Gen.1.1-Gen.1.19"
annotateType="commentary" sID="gen1"
type="section"/> <div sID="gen2"
type="x-p"/><hi type="bold">La création de
l'univers</hi><div eID="gen2" type="x-p"/>
<div sID="gen3" type="x-p"/>Avant que rien
n'existe de tout………….<div eID="gen4"
type="x-p"/> <div annotateRef="Gen.1.1-Gen.1.19"
annotateType="commentary" eID="gen1"
type="section"/> <br>
Genesis 1:2: <br>
Genesis 1:3: <br>
Genesis 1:4: <br>
Genesis 1:5: <br>
Genesis 1:6: <br>
Genesis 1:7: <br>
Genesis 1:8: <br>
Genesis 1:9: <br>
Genesis 1:10: <br>
</blockquote>
I don't know if this is normal: Gen.1.2 is empty, does
it mean no link entry? <br>
<br>
Best regards, <br>
<br>
--yvand <br>
<br>
<br>
Le 23/07/2020 à 23:51, Troy A. Griffitts a écrit : <br>
<blockquote type="cite">Hey yvand, <br>
<br>
My apologies for not getting back with you. osis2mod
isn't my domain these days, so I am not sure what the
current behavior is for annotateRef. I am pretty sure
linking works, and the normal way for linking is the
provide osisID="Gen.1.1 Gen.1.2 Gen1.3" <br>
<br>
You an test linking by using any of the lookup tools,
like diatheke, or I use sword/examples/cmdline/lookup.
<br>
<br>
e.g., ./lookup FreCJE Gen.1.2 <br>
<br>
I'd have to dig into the source for osis2mod and how
it handles annotateRef ranges, but I would think it
should work the same as osisID verse lists. <br>
<br>
Troy <br>
<br>
<br>
<br>
On 7/23/20 6:44 PM, yvand wrote: <br>
<blockquote type="cite">Thanks Greg for your quick
reply with explanation! <br>
<br>
I thought there was a bug and "link entries" were
not taken into consideration, when using osis2mod.
Is there a simple way to test if a commentary module
contains link entries? I tried with mod2imp to
export FreCJE but it only shows verses with attached
commentary ($$$Genesis 1:2 is missing for instance).
Maybe I misunderstood "link entries"
functionality... <br>
<br>
I believe it worked as expected in the past (at
least with Xiphos), but maybe I am wrong. <br>
<br>
Unfortunately I am not familiar with C/C++ and with
the sword engine, so I am not able to offer you a
patch. <br>
<br>
I understand the issues you pointed and it doesn't
seem easy. Currently, there are still questions, for
instance: how will operate the engine if there are
multiple commentaries starting with Gen.1.1 in the
source, like : <br>
<br>
<blockquote type="cite"><div ...
annotateRef="Gen.1.1">...</div> <br>
<div ...
annotateRef="Gen.1.1-Gen.1.16">...</div>
<br>
<div ...
annotateRef="Gen.1.1-Gen.1.31">...</div>
<br>
</blockquote>
I guess I will now give up for this feature. <br>
<br>
--yvand <br>
<br>
_______________________________________________ <br>
sword-devel mailing list: <a
class="moz-txt-link-abbreviated"
href="mailto:sword-devel@crosswire.org"
moz-do-not-send="true">sword-devel@crosswire.org</a>
<br>
<a class="moz-txt-link-freetext"
href="http://www.crosswire.org/mailman/listinfo/sword-devel"
moz-do-not-send="true">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
<br>
Instructions to unsubscribe/change your settings at
above page <br>
</blockquote>
_______________________________________________ <br>
sword-devel mailing list: <a
class="moz-txt-link-abbreviated"
href="mailto:sword-devel@crosswire.org"
moz-do-not-send="true">sword-devel@crosswire.org</a>
<br>
<a class="moz-txt-link-freetext"
href="http://www.crosswire.org/mailman/listinfo/sword-devel"
moz-do-not-send="true">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
<br>
Instructions to unsubscribe/change your settings at
above page <br>
</blockquote>
_______________________________________________ <br>
sword-devel mailing list: <a
class="moz-txt-link-abbreviated"
href="mailto:sword-devel@crosswire.org"
moz-do-not-send="true">sword-devel@crosswire.org</a> <br>
<a class="moz-txt-link-freetext"
href="http://www.crosswire.org/mailman/listinfo/sword-devel"
moz-do-not-send="true">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
<br>
Instructions to unsubscribe/change your settings at
above page <br>
</blockquote>
_______________________________________________ <br>
sword-devel mailing list: <a
class="moz-txt-link-abbreviated"
href="mailto:sword-devel@crosswire.org"
moz-do-not-send="true">sword-devel@crosswire.org</a> <br>
<a class="moz-txt-link-freetext"
href="http://www.crosswire.org/mailman/listinfo/sword-devel"
moz-do-not-send="true">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
<br>
Instructions to unsubscribe/change your settings at above
page<br>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
sword-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sword-devel@crosswire.org" moz-do-not-send="true">sword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/sword-devel" moz-do-not-send="true">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
sword-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sword-devel@crosswire.org" moz-do-not-send="true">sword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/sword-devel" moz-do-not-send="true">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
sword-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sword-devel@crosswire.org" moz-do-not-send="true">sword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/sword-devel" moz-do-not-send="true">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
sword-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/sword-devel">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
</body>
</html>