<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Nope, sorry Greg. I reviewed and approved of it :)</p>
<p>Applied.<br>
</p>
<br>
<div class="moz-cite-prefix">On 03/27/2018 08:43 AM, Greg Hellings
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAHxvOVJVkA7fEC+WP4_1p0tDWJgeBggbR6-gCnTQmctP08j+SQ@mail.gmail.com">
<div dir="ltr">Troy,
<div><br>
</div>
<div>I know you were working on the repo quite a bit over the
weekend. I didn't see this patch land. Did I miss it in the
commit emails?</div>
<div><br>
</div>
<div>--Greg</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Mar 21, 2018 at 12:32 AM, Troy
A. Griffitts <span dir="ltr"><<a
href="mailto:scribe@crosswire.org" target="_blank"
moz-do-not-send="true">scribe@crosswire.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>Thanks for the patch, Greg. Yes. Agreed it is not
intuitive to the uninitiated. The warring factions are
that a module key can be changed with a reference directly
to its key, the module being oblivious to that fact that
it changed. Also, a module position might be incremented
but never asked to do all the heavy work to render the
entry. We went with a manual trigger that renders the
entry of a module when desired. I tried to help by not
simply naming the method as a getter, getRenderText(), but
instead renderText() to imply this activates the
rendering, not simply retrieving the rendering. It's not
perfect.<br>
<br>
Thanks again for the patch.<span class="HOEnZb"><font
color="#888888"><br>
<br>
Troy</font></span>
<div>
<div class="h5"><br>
<br>
<div class="gmail_quote">On March 20, 2018 8:33:21 PM
MST, Greg Hellings <<a
href="mailto:greg.hellings@gmail.com"
target="_blank" moz-do-not-send="true">greg.hellings@gmail.com</a>>
wrote:
<blockquote class="gmail_quote" style="margin:0pt
0pt 0pt 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Mar 20, 2018
at 10:21 PM, Troy A. Griffitts <span
dir="ltr"><<a
href="mailto:scribe@crosswire.org"
target="_blank" moz-do-not-send="true">scribe@crosswire.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div>If I had to guess, I suspect diatheke
is not calling renderText before asking
for the header. The renderText method
triggers all entryAttributes to be
filled. The header is an entryAttribute.</div>
</blockquote>
<div><br>
</div>
<div>Spot on. If I were offering commentary,
I would call that a bug in the UX of the
API. But I do get why it is that way.
Attaching a patch that solves the problem.</div>
<div><br>
</div>
<div>--Greg</div>
<div> </div>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div>
<div>
<div class="m_7955669042359012047h5"><br>
<br>
<div class="gmail_quote">On March
20, 2018 8:13:41 PM MST, Greg
Hellings <<a
href="mailto:greg.hellings@gmail.com"
target="_blank"
moz-do-not-send="true">greg.hellings@gmail.com</a>>
wrote:
<blockquote class="gmail_quote"
style="margin:0pt 0pt 0pt
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">To be quite
specific: diatheke does not
encounter that header in the
preverse content until it
reaches Psalm 3:2 for some
reason that is beyond my ken.
Therefore, it is properly
rendering that content as
preverse, but it has attached
it to the wrong verse. Output
from my slightly modified
diatheke confirms this:
<div><br>
</div>
<div>
<div>$ ./inst/bin/diatheke
-b KJV -o h -f Plain -k Ps
3</div>
<div>key: Psalms 3:1</div>
<div>header: </div>
<div>Psalms 3:1: LORD, how
are they increased that
trouble me! many are they
that rise up against me.</div>
<div>key: Psalms 3:2</div>
<div>header: <title
canonical="true"
type="section"><w
savlm="strong:H04210">A
Psalm</w> <w
savlm="strong:H01732">of
David</w>, <w
savlm="strong:H01272">when
he fled</w> <w
savlm="strong:H06440">from</w>
<w
savlm="strong:H053">Absalom</w<wbr>>
<w
savlm="strong:H01121">his
son</w>.</title></div>
<div>A Psalm of David, when
he fled from Absalom his
son.</div>
<div>Psalms 3:2: Many there
be which say of my soul,
There is no help for him
in God. Selah.</div>
<div><br>
</div>
<div>--Greg</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On
Tue, Mar 20, 2018 at 9:53
PM, Greg Hellings <span
dir="ltr"><<a
href="mailto:greg.hellings@gmail.com"
target="_blank"
moz-do-not-send="true">greg.hellings@gmail.com</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div dir="ltr">It's easier
to see the problem when
using plain formatting:
<div><br>
</div>
<div>
<div>$ diatheke -b KJV
-o h -f Plain -k Ps
3</div>
<div>Psalms 3:1: LORD,
how are they
increased that
trouble me! many are
they that rise up
against me.</div>
<div>A Psalm of David,
when he fled from
Absalom his son.</div>
<div>Psalms 3:2: Many
there be which say
of my soul, There is
no help for him in
God. Selah.</div>
<div>Psalms 3:3: But
thou, O LORD, art a
shield for me; my
glory, and the
lifter up of mine
head.</div>
<div>Psalms 3:4: </div>
<div>I cried unto the
LORD with my voice,
and he heard me out
of his holy hill.
Selah.</div>
<div>Psalms 3:5: I
laid me down and
slept; I awaked; for
the LORD sustained
me.</div>
<div>Psalms 3:6: I
will not be afraid
of ten thousands of
people, that have
set themselves
against me round
about.</div>
<div>Psalms 3:7:
Arise, O LORD; save
me, O my God: for
thou hast smitten
all mine enemies
upon the cheek bone;
thou hast broken the
teeth of the
ungodly.</div>
<div>Psalms 3:8:
Salvation belongeth
unto the LORD: thy
blessing is upon thy
people. Selah.</div>
<div>(KJV)</div>
</div>
<span
class="m_7955669042359012047m_-2037599869492834402HOEnZb"><font
color="#888888">
<div><br>
</div>
<div>--Greg</div>
<div><br>
</div>
</font></span></div>
<div
class="m_7955669042359012047m_-2037599869492834402HOEnZb">
<div
class="m_7955669042359012047m_-2037599869492834402h5">
<div
class="gmail_extra"><br>
<div
class="gmail_quote">On
Tue, Mar 20, 2018
at 9:50 PM, Greg
Hellings <span
dir="ltr"><<a
href="mailto:greg.hellings@gmail.com" target="_blank"
moz-do-not-send="true">greg.hellings@gmail.com</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0
0 0
.8ex;border-left:1px
#ccc
solid;padding-left:1ex">
<div dir="ltr">I'm
not so sure
your initial
assertion is
correct.
<div><br>
</div>
<div>
<div>$
diatheke -b
KJV -o h -k Ps
3</div>
<div>Psalms
3:1: <w
savlm="strong:H03068"><seg><di<wbr>vineName>Lord</divineName></se<wbr>g></w>,
<w
savlm="strong:H07231">how
are they
increased</w>
<w
savlm="strong:H06862">that
trouble</w> <w savlm="strong:H07227">me! many</w>
<transChange
type="added">are</transChange> <w
savlm="strong:H06965">they
that rise
up</w>
against me.</div>
<div><title
canonical="true" type="section"><w savlm="strong:H04210">A
Psalm</w>
<w
savlm="strong:H01732">of
David</w>, <w savlm="strong:H01272">when he fled</w>
<w
savlm="strong:H06440">from</w>
<w
savlm="strong:H053">Absalom</w<wbr>>
<w
savlm="strong:H01121">his
son</w>.</title>Psalms 3:2: <w
savlm="strong:H07227">Many</w>
<transChange type="added">there be</transChange> <w
savlm="strong:H0559">which
say</w>
<w
savlm="strong:H05315">of
my
soul</w>,
<transChange type="added">There is</transChange> <w
savlm="strong:H03444">no
help</w>
<w
savlm="strong:H0430">for
him in
God</w>.
<w
savlm="strong:H05542">Selah</w<wbr>>.</div>
<div><br>
</div>
<div>If you
notice
carefully, the
canonical
title is
there. It is
just
misplaced. It
comes after
the text of
Psalm 3:1 and
not before.</div>
<div><br>
</div>
<div>--Greg</div>
<div
class="gmail_extra"><br>
<div
class="gmail_quote">
<div>
<div
class="m_7955669042359012047m_-2037599869492834402m_2175382381340732959h5">On
Tue, Mar 20,
2018 at 4:40
PM, David
Haslam <span
dir="ltr"><<a
href="mailto:dfhdfh@protonmail.com" target="_blank"
moz-do-not-send="true">dfhdfh@protonmail.com</a>></span>
wrote:<br>
</div>
</div>
<blockquote
class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<div
class="m_7955669042359012047m_-2037599869492834402m_2175382381340732959h5">
<div>Maybe
someone could
patch diatheke
to fix this?</div>
<span
class="m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-im
m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-HOEnZb">
<div> <br>
</div>
<div
class="m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-m_4619959956326407951protonmail_signature_block">Best
regards, David
</div>
<div> <br>
</div>
<div> <br>
</div>
<div
id="m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-m_4619959956326407951protonmail_mobile_signature_block">Sent
from
ProtonMail
Mobile</div>
</span>
<div
class="m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-HOEnZb">
<div
class="m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-h5">
<div> <br>
<div>
<div> <br>
</div>
On Wed, Mar
14, 2018 at
12:14, David
Haslam <<a
href="mailto:dfhdfh@protonmail.com" target="_blank"
moz-do-not-send="true">dfhdfh@protonmail.com</a>>
wrote:</div>
<blockquote
class="m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-m_4619959956326407951protonmail_quote"
type="cite">
<div>Diatheke
does not
output the
canonical
Psalm titles
when
output option
h is used.</div>
<div> <br>
</div>
<div>Try this
and see what I
mean.</div>
<div> <br>
</div>
<div>diatheke
-b KJV -o h -k
Ps 3</div>
<div> <br>
</div>
<div>This is a
significant
lack of
feature.</div>
<div> <br>
</div>
<div>Best
regards,</div>
<div> <br>
</div>
<div>David</div>
<div> <br>
</div>
<div
id="m_7955669042359012047m_-2037599869492834402m_2175382381340732959m_-3347557508244250965gmail-m_4619959956326407951protonmail_mobile_signature_block">Sent
from
ProtonMail
Mobile</div>
</blockquote>
</div>
</div>
</div>
<br>
</div>
</div>
______________________________<wbr>_________________<br>
sword-devel
mailing list:
<a
href="mailto:sword-devel@crosswire.org"
target="_blank" moz-do-not-send="true">sword-devel@crosswire.org</a><br>
<a
href="http://www.crosswire.org/mailman/listinfo/sword-devel"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://www.crosswire.org/mailm<wbr>an/listinfo/sword-devel</a><br>
Instructions
to
unsubscribe/change
your settings
at above page<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
<span
class="m_7955669042359012047HOEnZb"><font
color="#888888">
-- <br>
Sent from my Android device with K-9
Mail. Please excuse my brevity.</font></span></div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
-- <br>
Sent from my Android device with K-9 Mail. Please
excuse my brevity.</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>