<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I’ve had family visting this weekend. I’d like to look at it more closely. The code tries to be very careful in how it handles titles before the first verse of a chapter. The patches certainly solve a bug where it appends NT intros to the OT. <div class=""><br class=""></div><div class="">DM</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 25, 2016, at 9:16 AM, Troy A. Griffitts <<a href="mailto:scribe@crosswire.org" class="">scribe@crosswire.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
Dear John,<br class="">
<br class="">
I've applied your osisheadings patch mentioned below. Thank you!<br class="">
<br class="">
DM, do you have any comments on the osis2mod patches? You have been
the pumpkin holder for that tool for a while now. I am happy to
apply the patches but, of course, want to defer to you first.<br class="">
<br class="">
Troy<br class="">
<br class="">
<br class="">
<div class="moz-cite-prefix">On 06/13/2016 07:35 PM, John Austin
wrote:<br class="">
</div>
<blockquote cite="mid:575EEEF4.8020809@gmail.com" type="cite" class="">I'm
updating old modules in IBT's repository to use CrossWire best
practice OSIS, using usfm2osis.py. So these OSIS files are
CrossWire standard, but the corner cases are revealing some bugs
to fix. I've reported these on Jira, along with patches, but
mention them here in case there is discussion to be had.
<br class="">
<br class="">
osisheadings.cpp:
<br class="">
- Canonical pre-verse Psalm titles are being filtered out by the
osis-headings filter (like Psalm 10 in SynodalProt which has a
canonical title before verse 1).
<br class="">
<br class="">
osis2mod.cpp:
<br class="">
- Currently New Testament introductory material is appended to the
end of Malachi rather than being prepended to Matthew's
introduction.
<br class="">
<br class="">
- A majorSection osis2mod.cpp patch from Dec 2014 causes new
problems. Introduction text is now lost when majorSection titles
appear in the Bible or Testament introduction. I believe both the
original issue and the new issues can be fixed by treating
majorSection titles (and subSection titles for good measure) as
regular section divs in terms of pre-verse content. Testing has
shown this to work perfectly on IBT's new UZV module which uses
majorTitles in many places (Bible & Testament introductions,
Proverbs, and Daniel).
<br class="">
<br class="">
-john
<br class="">
<br class="">
_______________________________________________
<br class="">
sword-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a>
<br class="">
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/sword-devel">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
<br class="">
Instructions to unsubscribe/change your settings at above page
<br class="">
</blockquote>
<br class="">
</div>
_______________________________________________<br class="">sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" class="">sword-devel@crosswire.org</a><br class=""><a href="http://www.crosswire.org/mailman/listinfo/sword-devel" class="">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br class="">Instructions to unsubscribe/change your settings at above page</div></blockquote></div><br class=""></div></body></html>