<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Thanks Mark for the report. I've
applied a different fix in diatheke which had an unsafe call to
retain a pointer to temporary object. It just 'happened' to work
previous. This was the reason for this signature change in the
method-- to better advertise to developers that they shouldn't
hold on to these pointers beyond the stack of the initial call.
It's slightly more expensive, but safer and clearer and on a
method (renderText) which shouldn't need the extra optimization.<br>
<br>
Thanks again for the report; you led me right to the problem.<br>
<br>
Troy<br>
<br>
On 07/31/2013 01:26 PM, Mark Trompell wrote:<br>
</div>
<blockquote
cite="mid:CAEPa5yk=Q+UMUtCSQUtv_B7jbNcgneaor5-hG9Mqws0bDfrCYg@mail.gmail.com"
type="cite">
<pre wrap="">attached patch makes diatheke somewhat work again.
I wonder why the cast doesn't work.
I tried this too, but doesn't help:
diff --git a/include/swmodule.h b/include/swmodule.h
index 16fb301..04dde03 100644
--- a/include/swmodule.h
+++ b/include/swmodule.h
@@ -47,7 +47,7 @@ class SWFilter;
#define SEARCHFLAG_MATCHWHOLEENTRY 4096
#define SWMODULE_OPERATORS \
- operator const char *() { return renderText(); } \
+ operator const char *() { return renderText().c_str(); } \
operator SWKey &() { return *getKey(); } \
operator SWKey *() { return getKey(); } \
SWModule &operator <<(const char *inbuf) { setEntry(inbuf);
return *this; } \
On Wed, Jul 31, 2013 at 10:18 AM, Mark Trompell <a class="moz-txt-link-rfc2396E" href="mailto:mark@foresightlinux.org"><mark@foresightlinux.org></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I did some bisecting that shows r2921 is the first commit that breaks
diatheke, so I think the revert of the qt support work wasn't complete
On Wed, Jul 31, 2013 at 9:38 AM, Mark Trompell <a class="moz-txt-link-rfc2396E" href="mailto:mark@foresightlinux.org"><mark@foresightlinux.org></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Ok, that's not because of r2922, but output of diatheke is crippled.
On Wed, Jul 31, 2013 at 9:21 AM, Mark Trompell <a class="moz-txt-link-rfc2396E" href="mailto:mark@foresightlinux.org"><mark@foresightlinux.org></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">diatheke is broken probably beacuse of r2922. I try to revert to confirm...
Btw, this change forces changes in xiphos and probably every other frontend.
On Wed, Jul 31, 2013 at 4:24 AM, Troy A. Griffitts <a class="moz-txt-link-rfc2396E" href="mailto:scribe@crosswire.org"><scribe@crosswire.org></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I understand apologies for the unacceptable delay will mean nothing.
SWORD 1.7.0RC1 is available from the following link:
<a class="moz-txt-link-freetext" href="http://crosswire.org/sword/alpha/alpha/sword-1.7.0RC1.tar.gz">http://crosswire.org/sword/alpha/alpha/sword-1.7.0RC1.tar.gz</a>
Please try your projects with the RC.
(and please update your ChangeLog entries for the official package)
May God be pleased by all our hard work and mercifully use this for His
Kingdom. Thank you for participating in this long awaited release.
Troy
_______________________________________________
sword-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/sword-devel">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page
</pre>
</blockquote>
<pre wrap="">
--
Mark Trompell
Foresight Linux Xfce Edition
Cause your desktop should be freaking cool
(and Xfce)
</pre>
</blockquote>
<pre wrap="">
--
Mark Trompell
Foresight Linux Xfce Edition
Cause your desktop should be freaking cool
(and Xfce)
</pre>
</blockquote>
<pre wrap="">
--
Mark Trompell
Foresight Linux Xfce Edition
Cause your desktop should be freaking cool
(and Xfce)
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sword-devel mailing list: <a class="moz-txt-link-abbreviated" href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a>
<a class="moz-txt-link-freetext" href="http://www.crosswire.org/mailman/listinfo/sword-devel">http://www.crosswire.org/mailman/listinfo/sword-devel</a>
Instructions to unsubscribe/change your settings at above page</pre>
</blockquote>
<br>
</body>
</html>