<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 12, 2013 at 2:51 PM, Jaak Ristioja <span dir="ltr"><<a href="mailto:jaak@ristioja.ee" target="_blank">jaak@ristioja.ee</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
</div>Hi!<br>
<br>
What's the integration status on this patch?<br>
<br>
Blessings,<br>
Jaak<br></blockquote><div><br></div><div style>Can we allow changes which are not bare-minimum build-breakers, such as restructuring the includes, be a later issue for the next next release and just get 1.7.0 out the door, please?</div>
<div style><br></div><div style>Also, what prevents you from having</div><div style>-I/usr/include -I/usr/include/sowrd</div><div style><br></div><div style>and then having #include <sword/foo.h> and having it all work just as planned?</div>
<div style><br></div><div style>--Greg</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
PS: Is Troy the only one with access to apply this?<br>
<div><div class="h5"><br>
On 10.06.2013 22:49, Jaak Ristioja wrote:<br>
> Argh, someone must have changed things on SVN lately, so this<br>
> patch was invalid for the current trunk... I wish you guys would<br>
> learn git or something. Anyway, here's something which should apply<br>
> to SVN 2819, I hope.<br>
><br>
> SHA1SUM: 071a4fb64f1d0c2ed5d746d08791592f76eaf633<br>
><br>
> Blessings, Jaak<br>
><br>
> On 10.06.2013 22:34, Jaak Ristioja wrote:<br>
>> Attached is a patch for this. Please apply.<br>
><br>
>> SHA1SUM: 9a99e34ce419ea3288a32148d431ec971fb0e675<br>
><br>
>> Blessings, Jaak<br>
><br>
><br>
>> On 10.06.2013 19:38, Jaak Ristioja wrote:<br>
>>> I'm working on the patch but here's a short overview of the<br>
>>> problem, in case discussion is required. The problem is that<br>
>>> source code using Sword can't do stuff like:<br>
><br>
>>> #include <sword/versekey.h><br>
><br>
>>> This is VERY BAD, because we must do<br>
><br>
>>> #include <versekey.h><br>
><br>
>>> and provide -I/path/to/sword/includes/ to the compiler every<br>
>>> time. The problem with this approach is that versekey.h might<br>
>>> also exist in /usr/include or in other -I/include/paths.<br>
>>> Additionally, this makes the #include list rather<br>
>>> incomprehensible, especially when we want to sort it<br>
>>> alphabetically. There's no telling what <versekey.h> refers to<br>
>>> - is it part of Sword, part of something else, or a typo (e.g.<br>
>>> maybe this needs to be "versekey.h").<br>
><br>
>>> Why #includes like <sword/versekey.h> don't work is that the<br>
>>> Sword headers themselves use includes like <versekey.h><br>
>>> instead of "versekey.h" which is correct. If I don't include<br>
>>> -I/usr/include/sword in my compiler arguments, but #include<br>
>>> <sword/versekey.h>, the versekey.h file tries to #include<br>
>>> <swkey.h> which fails because it can't find the file in in the<br>
>>> include path.<br>
><br>
>>> The *.cpp files in Sword also need to use "" instead of <> to<br>
>>> distinguish between header system and local header files.<br>
><br>
>>> Afaik this is just best practice. Existing code using #include<br>
>>> <versekey.h> etc will continue to work as long as the<br>
>>> -I/path/to/sword/includes exists.<br>
><br>
><br>
>>> Blessings, Jaak<br>
><br>
>>> On 10.06.2013 19:21, Jaak Ristioja wrote:<br>
>>>> Actually I just remembered another serious flaw which causes<br>
>>>> a headache for developers using Sword. I'll write a patch<br>
>>>> ASAP.<br>
><br>
>>>> Blessings, Jaak<br>
><br>
>>>> On 10.06.2013 09:43, Troy A. Griffitts wrote:<br>
>>>>> Jaak,<br>
>>>>><br>
>>>>> I accepted and applied your header file patch nearly 5<br>
>>>>> months ago. Are you telling me that you still have 549<br>
>>>>> warnings from SWORD headers?<br>
>>>>><br>
>>>>> Troy<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> On 06/09/2013 11:55 PM, Jaak Ristioja wrote: On 09.06.2013<br>
>>>>> 23:21, Troy A. Griffitts wrote:<br>
>>>>>>>> I don't think other developers are getting ignored.<br>
>>>>>>>> Please be specific. Just because I don't accept a<br>
>>>>>>>> patch doesn't mean a developer is getting ignored.<br>
>>>>>>>><br>
>>>>>>>> In fact, many times trying to make this release, when<br>
>>>>>>>> people complain that we need something fixed for<br>
>>>>>>>> this release, I ask for a simple testsuite addition<br>
>>>>>>>> to show the problem and desired result, and don't get<br>
>>>>>>>> a response.<br>
>>>>>>>><br>
>>>>>>>> I don't believe the problem is as you think it is<br>
>>>>>>>> Jaak. Many people whine about this or that. Not all<br>
>>>>>>>> whine for things to go in the same direction.<br>
>>>>>>>><br>
>>>>>>>> Everyone whines for a release but not everyone is<br>
>>>>>>>> willing to help submit tests and then fixes for those<br>
>>>>>>>> tests.<br>
>>>>>>>><br>
>>>>>>>> You stated that you would get involved to help, but<br>
>>>>>>>> you only submit things for which I previously told<br>
>>>>>>>> you I wasn't interested in accepting (worrying about<br>
>>>>>>>> pedantic warnings whose changes often make the code<br>
>>>>>>>> less readable and do nothing to improve any of the<br>
>>>>>>>> real problems for the end user. Though I do<br>
>>>>>>>> appreciate a few of the warning fixes you submitted,<br>
>>>>>>>> a few being actual bug fixed too (thank you)-- I'm<br>
>>>>>>>> just ranting right now.)<br>
>>>>> As a BibleTime developer, I want to available tools (-Wall,<br>
>>>>> -Wextra, cppcheck, etc) to fix any errors in my code. Due<br>
>>>>> to the Sword header files which generate a lot of warnings<br>
>>>>> this task is VERY inconvenient. For example, when I compile<br>
>>>>> the whole of BibleTime with GCC, I get 549 warnings from<br>
>>>>> Sword headers (mostly for unused arguments) - how am I<br>
>>>>> supposed to find the warnings relevant for BibleTime? This<br>
>>>>> alone often makes it a pain to develop BibleTime and gives<br>
>>>>> me enough reason to want to fork Sword.<br>
>>>>><br>
>>>>> Turning on and fixing pedantic warnings will help find real<br>
>>>>> bugs. FACT! Forcing developers to work blindfolded will<br>
>>>>> not help anyone.<br>
>>>>><br>
>>>>> The same tools can be used to find bugs in Sword code, and<br>
>>>>> SHOULD regularly be used for this purpose to ensure code<br>
>>>>> quality. As is obvious these are currently NOT BEING USED<br>
>>>>> by Sword developers. However, when things eventually<br>
>>>>> break, users complain to the BibleTime project. Hence, it<br>
>>>>> is also in the interests of front-ends to ensure that the<br>
>>>>> code of Sword is of good quality. Again - if Sword won't<br>
>>>>> work to ensure this and wont let us in to fix things, we<br>
>>>>> have another reason to fork.<br>
>>>>><br>
>>>>> This again leads us to the issue of attracting new<br>
>>>>> developers to Sword. I don't want to write on this more<br>
>>>>> than necessary to provide a small argument for my<br>
>>>>> conclusion. Afaik the current situation isn't working well.<br>
>>>>> Biggest obstacles for me personally include working<br>
>>>>> blindfolded, submitting patches by e-mail and not getting<br>
>>>>> enough feedback for (ignored) patches and other emails.<br>
>>>>><br>
>>>>> To conclude - maybe its just me, but altogether I really<br>
>>>>> feel it were easier to maintain a parallel fork (at<br>
>>>>> minimal to provide set of patches) than to waste my time<br>
>>>>> writing long letters trying to make this relationship work<br>
>>>>> in its current form. I accept whatever path the Sword<br>
>>>>> project takes, but if it's not enough for the needs of<br>
>>>>> BibleTime and our devs, we will make our own choices as<br>
>>>>> well.<br>
>>>>><br>
>>>>><br>
>>>>> Blessings, Jaak The BibleTime team<br>
>>>>><br>
>>>>><br>
>>>>> PS: I apologize if this late-night response is<br>
>>>>> incomprehensible.<br>
>>>>>><br>
>>>>>> _______________________________________________<br>
>>>>>> sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
>>>>>> <a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
>>>>>> Instructions to unsubscribe/change your settings at above<br>
>>>>>> page<br>
>>>>><br>
>>>>><br>
>>>>> _______________________________________________ sword-devel<br>
>>>>> mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
>>>>> <a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
>>>>> Instructions to unsubscribe/change your settings at above<br>
>>>>> page<br>
><br>
><br>
><br>
><br>
>>>> _______________________________________________ sword-devel<br>
>>>> mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
>>>> <a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
>>>> Instructions to unsubscribe/change your settings at above<br>
>>>> page<br>
><br>
><br>
><br>
>>> _______________________________________________ sword-devel<br>
>>> mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
>>> <a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
>>> Instructions to unsubscribe/change your settings at above page<br>
><br>
><br>
><br>
><br>
><br>
>> _______________________________________________ sword-devel<br>
>> mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
>> <a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
>> Instructions to unsubscribe/change your settings at above page<br>
><br>
><br>
><br>
><br>
><br>
> _______________________________________________ sword-devel mailing<br>
> list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
> <a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a> Instructions<br>
> to unsubscribe/change your settings at above page<br>
><br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
</div></div>Version: GnuPG v2.0.20 (GNU/Linux)<br>
<br>
iQgcBAEBAgAGBQJRuNFMAAoJEEqsYmEt1rCO29k//AoJs/O+4El40pOJ7Vnnk6LJ<br>
DTD07ykOWMdJLpfqXyxsao8vEdCGSZUp2HArHw+B/1bsnuQtdq5jObUngPUj2RBL<br>
VqQDJ2f8miNl9nc7Og6wM3zz34r647lE9sxm9gnCC/wiH3SivGJMUMy9Z1AprKNb<br>
bDwArC5dGMhi55+qrSdxSBpqhA2lod9MHYY/1avAqHP7ftY1Na1PzC9wujMWEhW8<br>
LJvYp8+s/m6hgfBPy45dB0n/TXJZQegRuKWaue3UKXudYWteWctSFj2TnCrWaar3<br>
6Rt6nE5X0pdkh4x7R6Du1vxk55d/JTsoYzQcb8sAT1GqRt5JKxoNLrZKQ0EuQLoj<br>
ItHANgEOtGNjfNN/j9qWl3WIPSxaXCe/FTgj36zJDRcpI2y5rUFjqK+lCEa9Pc29<br>
aWr4I0NwnRvHtrArizEH2rUk7kF0Ah8KN+rRpI/vq8Ikalr/GoCVfBHsB6cOHyol<br>
e3qeClxMJE2rObqE40w1fH1k/DDXkka8WBQOqV09iZvgL+BjqZY2HBVnYS84VnwM<br>
KRhPOVJM+es5oB2LtrnK2D0ZTbiiyKf8lEPS/FZVbmq1AYQ1q3e0RsY+X9qZiz0L<br>
p4wuZIDPLs4xlo0SIGLMP/dAdnlGQo2lFLrVcHE3n/D/6ylG1dZgpEMluc9/iEx3<br>
0flkixwbYkULFoZ3GERb8KuXT/82JIKZy37AzGqq1smmi3A47qKCfmDyg1daDiJP<br>
ic9kbj69MiGgqCSTHscSDGjnkcwNY8cRe95laoWny7IsnEKDvpQoeIyoNvjrHo0e<br>
Pln0KxXhrDHRlE3iDy0KsHtEFpw56KL2ToFyUuJX15mh0H+M74xxnqBIHoS9V8/f<br>
/JVcDUedMiVlrFRERPlQ6DKF6BlMNUlW/59jzSAyW0zSG0QgnXxB7Z9LFprOa7wM<br>
9FG+h5EjLH6odMqiX2HowFFApzvZWPp90IIPl+Bvk5uWBguNEiK8+Eoz2IeD+p1V<br>
L8LVYruNIgXqgeKdIodtIw+Ru1PBIVwdGzSn6hm5PhUAEdL56fwTm9lvR5Frk4Cz<br>
Ua0HcllvZMsmUwouShGfIi13wIAc85onrU257h3uLQcomnNvl/nQlJtYrOcydi4D<br>
qQVp3X7h1ZKm87MG5rKUhAQBhA2eA/9VhnFejuZMdZQalzIYDVw1fZU7JzXr1+cq<br>
YZSsr/kNRE1oMiFkY4GouMbcmXM6DQ0WQ3Zmc4o070POCqmtS97RXRq0+Ah3S09N<br>
06aGfHpSfFcoXI6KF4g5SRv4EUAjzH996Y+aS2rF2bOCV9ttluoTdqB+OC651jV5<br>
oABRuXNVmbJ5Ea9yd45AOKwhZgAwr3zht68XeiUcWW3pctgUjFHHF0WXnmh9QWIF<br>
kcRd+bSXXqJ0QYjkLc2Y/d8ylpv3C0/dLQSgnMmODUnRSGtc4hnFdTnw6DYzOhmQ<br>
RbjZd5GmgcpMfzCb9tzpNOSyhodUwmJA2WukaAh5yJcb5tvJaOWDcQXekc81Zg/3<br>
EDyZT6EqvZU2XqVluAchE+cvAVfGOmQ1e7vWYCAYYRE9jEbD7JmHw2Pzl8s/Znzt<br>
yqWldVa84K/8Eg1MD4JfxJUbnkMjtWzD+fi6VH4y9Tydqm8N8f+Q0ZUpRFtJ/fLe<br>
TU+qGlxpDjnM7VM5uVGPQaF5G3tAxafuw+i+6wjP9ZPTJ9r0BxkwwMra11si/kB1<br>
aMh4pJzr0nKlo5cafM5ke2BsLx5wdl+Hd0xQn3qXVP8ZDOVWqjz7XTy1DyN2fPya<br>
WJaRfFXjLuCwxzV/RUJxynDH0jsI/wsP28+2TU9/jFL1CncBIBH6uHGyPhEK04Gv<br>
yCwZYX4iB/UVIPFp7g+G/pEHZTy5dR0GuL838F1oN8OSMdbGfn33Kb4U1+lAB4LP<br>
Nw/qEuci+2TDdo7C7emueU7QiT0WFRhAol8BlNbc/B7ndzve+Oeb+AQkPe1sAzlT<br>
CT87N8ZFM4mcC238LI24Smks4y59Mug6sSja6psdsPf1QXePnDOThZBqYIKxkRmh<br>
r0Ej3SdjfhnZ4uvIQXeqhQtSylUe+2dDn7m57I9u3fEg6qz3RqBAvgC1wowwqEhi<br>
F7oajohRaesc3U/yDT0U2loL+XdhIiySsRcpkF6C/+ci/zpGjJ2k/E3ahpf8EfBf<br>
2QtDEky0OBYb+c2As5oQzqTuLg9xhbx6eSZuB4VEQnrIVjd7U1+MmDw1F4eC2fsQ<br>
EXkDHZ4ztTdxhqd6EOIvm04M/z6+IzbX6Eppe5w8JdbGYTgXfJ2XRZjPp3OtKwOO<br>
BN+/ChTDbO1G96KrbbiEomNRiYUf2Be2NGFpdgWH/zs5n3AwjpS0e0z4h3U6n7wj<br>
1cQvzq7VBupQhWPRNsf3Sxmh9Ly8X8NRXMkIAl32qNLwhggc0mpckbBZgxlZFRRE<br>
SorKNN1KbbBi0q9hq3PWscB12W7UAZatpQ02eHLaPwlRL6MmgdpIn0oGgt07smlT<br>
rG2VwKAVhuyCJ92+LL/rWdWgp5J9P/P4toXqAj9dlkoOvtkQ4XTYv3uIvaXwcLWI<br>
esLWijNn9wAAlsMQ8EWR1f6aHhu+e7h2FOqPnuIRl/8I4JJgbpDNdhxD9PmkWr3z<br>
Ve0RYrte+WVCnEbbV8elN3VaNypsFcTLiwvEBgYIWGPK0ZjlCJdFesRM6bvs17tI<br>
DPQTv7NB+Fmt4/Tr6QUgbXX1jiU5xjiVNEN5CIWQUrdGc+Nh43yv429HAGgSJ9F9<br>
ecLbhzbKZUxBFpygcqtD<br>
=kxGp<br>
-----END PGP SIGNATURE-----<br>
<div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br>
</div></div></blockquote></div><br></div></div>