<div dir="ltr">Attached is a patch (I don't think I have commit privileges to that directory? If so, I can commit it directly.).<div><br></div><div style>--Greg</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sun, Jan 20, 2013 at 12:00 PM, Greg Hellings <span dir="ltr"><<a href="mailto:greg.hellings@gmail.com" target="_blank">greg.hellings@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Building the library (with CMake) now I get many warnings coming from examples/cmdline. Among those I get the following errors:<div><div>/home/greg/Source/sword/examples/cmdline/threaded_search.cpp:101: undefined reference to `sword::VerseKey::ParseVerseList(char const*, char const*, bool, bool)'</div>
<div>collect2: error: ld returned 1 exit status</div></div><div><div>/home/greg/Source/sword/examples/cmdline/verserangeparse.cpp:48: undefined reference to `sword::VerseKey::ParseVerseList(char const*, char const*, bool, bool)'</div>
<div>collect2: error: ld returned 1 exit status</div></div><div><div>/home/greg/Source/sword/examples/cmdline/search.cpp:102: undefined reference to `sword::VerseKey::ParseVerseList(char const*, char const*, bool, bool)'</div>
<div>collect2: error: ld returned 1 exit status</div></div><div><br></div><div>It looks like this has become parseVerseList now and you just missed those couple of places.</div><span class="HOEnZb"><font color="#888888"><div>
<br></div><div>--Greg</div>
</font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jan 19, 2013 at 10:13 AM, Troy A. Griffitts <span dir="ltr"><<a href="mailto:scribe@crosswire.org" target="_blank">scribe@crosswire.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In anticipation of a new release, I have a large checkin I'm about to commit which will break everything for everyone compiling with -Werror.<br>
<br>
We've been normalizing method names toward a clean API interface at 2.0. SWORD started 20+ years ago when there was not standard naming conventions. In fact, originally we tried to keep variable names less than 8 characters, as, at the time, some compilers stopped disambiguating after this. Besides these, there are a number of conventions we used back then for which standards have now become the norm: camelCase conventions, standard set/getProperty naming, and the like. We've been slowly moving toward these changes and have been deprecating old names for a few years now. What I'm about to introduces standard names for all methods within the SWKey and SWModule classes and deprecates the non standard names.<br>
<br>
A few not obvious changes:<br>
<br>
Headings() has been renamed to setIntros(bool) and bool isIntros()<br>
Headings() -- used to turn on chapter, book, testament, and module introductions, has frequently been a point of confusion with the global option "Headings" -- used to turn on and off section headings in the text. This new property name will hopefully remove that confusion.<br>
<br>
Error() has become popError(), as the functionality has always been to return and clear any error code for the object.<br>
<br>
The bindings are probably in a state of disarray now. I've updated the omniorb bindings. I'd appreciated any help with other stuff.<br>
<br>
I hope this doesn't cause too much of a headache for everyone. I hope these naming standards raise coherence to the look of our API for newcomers.<br>
<br>
Hope you are all at the start of a blessed new year,<br>
<br>
Troy<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org" target="_blank">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/<u></u>mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>