<div class="gmail_quote">On Tue, Oct 20, 2009 at 8:36 AM, Troy A. Griffitts <span dir="ltr"><<a href="mailto:scribe@crosswire.org">scribe@crosswire.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Thanks for the patch Nathan,<br>
<br>
Is this really necessary? This has been in the code for quite some time<br>
and BPBible has been working with swig bindings for quite some time with<br>
this in the code. I don't believe this inner class should ever be<br>
exposed in the bindings, as it is a mechanism we use in the<br>
implementation of a specific derived class, and not a basic interface.<br>
<br></blockquote><div>This isn't necessary for me; SWIG will give warnings about nested classes, but not errors (they just won't be wrapped).<br>It is actually possible to get round these restrictions, but here it isn't worth it.<br>
<br>The place I'd actually be a little more worried about the nested classes is in the av11n code, with VerseMgr::System, etc.<br><br><br clear="all">God Bless,<br>Ben<br>-------------------------------------------------------------------------------------------<br>
Multitudes, multitudes,<br> in the valley of decision!<br>For the day of the LORD is near<br> in the valley of decision.<br><br>Giôên 3:14 (ESV)<br><br></div></div>