On Mon, May 18, 2009 at 3:35 PM, Jonathan Marsden <span dir="ltr"><<a href="mailto:jmarsden@fastmail.fm">jmarsden@fastmail.fm</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">Ben Morgan wrote:<br>
<br>
> I didn't add regression tests... I'm not sure how workable they are. (though<br>
> they would probably be a good idea)<br>
<br>
</div>Can't we do osis2mod and then mod2osis (or even mod2imp) and<br>
store/compare that output, so that the comparison is of text? Or is<br>
there some reason why that can't work?<br>
</blockquote><div>Not really, I don't think. The round-trip may be somewhat important, but it is the bit in the middle that *really* needs testing. You can easily have it survive the round-trip but be wrong in the middle.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Given the number of module creation tool issues there seem to be, having<br>
some automated testing for the utilities seems worth at least some kind<br>
of attempt. If in a few months we learn that it didn't really help...<br>
well, OK, at least we tried :)<br>
<div class="im"></div></blockquote><div> Well, yes. It probably is a good idea, if this is the way that people are meant to import.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><br>
> These are (as far as I can see) critical issues and need (relatively)<br>
</div>> immediate fixing. ...<br>
<div class="im"><br>
> In some ways osis2mod changes are important to be released quickly.<br>
<br>
</div>In that case, IMO we have to declare these bugs as being important, and<br>
therefore we need for a very immediate SWORD 1.6.1 release to fix these<br>
issues! Maybe you could request a 1.6.1rc1 right away, and then if that<br>
works well for testers for a week or so, we can release 1.6.1 ?<br>
<div><div></div><div class="h5"></div></div></blockquote><div>This is part of why it makes sense for utilities to be released separately. The problem here isn't in the engine, so it doesn't necessarily make too much sense to have a release of the engine... <br>
However, I guess users expect the latest versions of the utilities in the latest version of the library - I guess this is more of an issue for future consideration... <br><br clear="all">God Bless,<br>Ben<br>-------------------------------------------------------------------------------------------<br>
Multitudes, multitudes,<br> in the valley of decision!<br>For the day of the LORD is near<br> in the valley of decision.<br><br>Giôên 3:14 (ESV)</div></div><br>