<br><br><div class="gmail_quote">2009/4/24 Jonathan Marsden <span dir="ltr"><<a href="mailto:jmarsden@fastmail.fm">jmarsden@fastmail.fm</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
>> src/utilfuns/ftplib.c: UNKNOWN<br>
<br>
Dmitrijs Ledkovs wrote:<br>
<br>
> It's LGPL v2+ with Incorrect FSF address.<br>
><br>
> Attaching a patch: ...<br>
<br>
I think patching is an incorrect approach to this.<br>
</blockquote><div><br>I made the patch a bit tongue in cheek.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Only the copyright holder can change the copyright of their code.<br>
Patching a copyright notice in packaging is, more or less by definition,<br>
the wrong thing to do. Stating in debian/copyright what the actual<br>
copyright of the file is, and why we believe it to be that if there is<br>
any ambiguity, is the correct approach to this situation, unless and<br>
until we can persuade the authors to update their code and release a<br>
version with an improved copyright notice.<br>
</blockquote><div><br>copyright has not been changed. Style of commenting was which is allowed under LGPL.<br>An address was update which is simply a pointer where the full text of the license can be obtained.<br><br>LGPL does grant the right to change the source code as long as we publish the new source. IMHO these two small changes fall under that. Upto Sword developer's to commit the patch or not.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
The goal isn't to make sure licencecheck -r . output looks good; it is<br>
to make sure that every file in the source tarball has a known DFSG-free<br>
copyright and license. It's simplest if licensecheck tells us all is<br>
well, but in the end licensecheck is just a tool. debian/copyright<br>
being complete and correct is much more important.<br>
</blockquote><div><br>I will submit bug report to licensecheck cause in my expectation it should pick up a license enclosed in funky commenting.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Jonathan<br>
<br>
_______________________________________________<br>
sword-devel mailing list: <a href="mailto:sword-devel@crosswire.org">sword-devel@crosswire.org</a><br>
<a href="http://www.crosswire.org/mailman/listinfo/sword-devel" target="_blank">http://www.crosswire.org/mailman/listinfo/sword-devel</a><br>
Instructions to unsubscribe/change your settings at above page<br>
</blockquote></div><br><br clear="all"><br>-- <br>With best regards<br><br><br>Dmitrijs Ledkovs (for short Dima),<br>Ледков Дмитрий Юрьевич<br><br>